scorecard - version:bump to v1.54.6 - #4529
Conversation
|
🤖 Finished Review · ✅ Success · Started 5:48 AM UTC · Completed 5:53 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.81 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4529 +/- ##
==========================================
- Coverage 62.06% 62.05% -0.02%
==========================================
Files 2603 2603
Lines 104477 104454 -23
Branches 29349 29339 -10
==========================================
- Hits 64848 64823 -25
+ Misses 39044 37774 -1270
- Partials 585 1857 +1272
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Review — scorecard: version bump to v1.54.6Verdict: ✅ Approve Automated Backstage version bump from v1.52.0 to v1.54.6 for the scorecard workspace. The PR updates dependency versions across 20
Findings
Dimensions reviewed
Previous runReview — scorecard version bump to v1.54.6Verdict: ✅ Approve This PR is an automated Backstage version bump from 1.52.0 to 1.54.6 in the Changes reviewed
Key observations
Low-severity notes
Previous run (2)Review — scorecard version bump to v1.54.6Verdict: ✅ Approve This is a clean automated Backstage version bump from v1.52.0 to v1.54.6 for the Changes reviewed
Config schema migration detailsThe
Both files add No correctness, security, or architectural concerns identified. Labels: Automated dependency version bump for Backstage framework Previous run (3)Review — ✅ ApproveBackstage version bump v1.52.0 → v1.54.6 for the scorecard workspace. This is an automated version bump created by Changes reviewed
Config schema migration detailBoth source file changes migrate from Backstage's callback-based
Existing tests in No findingsPrevious run (4)Review — scorecard version bump to Backstage v1.54.6Verdict: Approve ✅ SummaryThis is an automated Backstage version bump PR created by ScopeAll 20 changed files are confined to the
No source code, test files, or configuration logic was changed — this is a pure dependency version bump. AnalysisCorrectness: All Changeset bump level: The changeset uses Scope containment: All changes are within Security: No new non-Backstage dependencies introduced. All version bumps are within the existing Notes
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
the
ready-for-merge
The deprecated config.schema option was removed in @backstage/frontend-plugin-api 1.54. Migrate to the new configSchema top-level option using Zod v4. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Review · ❌ Terminated · Started 6:14 AM UTC · Ended 6:19 AM UTC Commit: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
ready-for-merge
|
🤖 Finished Review · ✅ Success · Started 6:14 AM UTC · Completed 6:19 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.87 |
The homepage plugin at 1.17.x uses the removed config.schema API which causes a blank page on Backstage 1.54. Version 1.18.0 has the configSchema/Zod v4 migration. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Review · ❌ Terminated · Started 7:59 AM UTC · Ended 8:04 AM UTC Commit: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
ready-for-merge
|
🤖 Finished Review · ✅ Success · Started 7:59 AM UTC · Completed 8:04 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.97 |
|
🤖 Review · ❌ Terminated · Started 8:58 AM UTC · Ended 9:09 AM UTC Commit: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
removed
the
ready-for-merge
fullsend-ai-review
Bot
added
the
ready-for-merge
|
🤖 Finished Review · ✅ Success · Started 8:58 AM UTC · Completed 9:09 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $4.00 |
|
🤖 Review · ❌ Terminated · Started 12:23 PM UTC · Ended 12:33 PM UTC Commit: |
|
| await expect(this.page.getByRole('article')).toContainText( | ||
| this.translations.emptyState.description, | ||
| ); | ||
| await expect( |
There was a problem hiding this comment.
[low] test-weakening
Assertion change from getByRole("article").toContainText(text) to getByText(text).toBeVisible() drops the structural check that the description text appears inside an element with role="article". The new assertion will pass even if the text moves outside the article container. Same weakening applies to scorecard.test.ts line 133. Likely necessitated by DOM changes in the Backstage version bump.
Suggested fix: Consider page.getByRole("article").getByText(text).toBeVisible() to preserve both structural and visibility checks.
fullsend-ai-review
Bot
added
ready-for-merge
|
🤖 Finished Review · ✅ Success · Started 12:23 PM UTC · Completed 12:33 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $3.39 |
2 participants
Backstage release v1.54.6 has been published, this Pull Request contains the changes to upgrade scorecard to this new release
Please review the changelog before approving, there may be manual changes needed:
Created by Version Bump 33595930462