fix: allow multiple configs listed in KUBECONFIG (#779) #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adietish
changed the title
adietish
force-pushed
the
issue-779
branch
14 times, most recently
from
3068a25 to
8c65c4d
Compare
adietish
force-pushed
the
issue-779
branch
6 times, most recently
from
9cce0e9 to
0526f10
Compare
sbouchet
approved these changes
Oct 17, 2024
Signed-off-by: Alexander Bartash <@AlexanderBartash>
* save kube conf files when current ctx or ns changes * watch all config files (redhat-developer#779) Signed-off-by: Andre Dietisheim <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #779
depends on redhat-developer/intellij-common#237
related to fabric8io/kubernetes-client#6240
This is a tentative, simplified fix where I override the kubernetes-client
io.fabric8.kubernetes.client.Configclass within the classpath of our plugin.A proper fix will patch kubernetes-client and then include the fixed client in our plugin. As pointed out in fabric8io/kubernetes-client#6253 (comment) the fixed client is 7.x (we're currently at 6.12) and possibly get backported to 6.13 if the fix is non-intrusive.