Repository navigation
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| force: false | ||
|
|
||
| - name: Deploy preview | ||
| uses: rossjrw/pr-preview-action@v1 |
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v4 | ||
| uses: JamesIves/github-pages-deploy-action@v4 |
…te the migration based on the Migration Factory Roles
stevefulme1
left a comment
stevefulme1
left a comment
There was a problem hiding this comment.
Review: v2 Preview
No blockers. Several items to address before GA.
Pin GitHub Actions to SHA (medium)
preview.yml and publish-github-pages.yml use mutable tags (@v4, @v1) for actions/checkout, actions/setup-node, rossjrw/pr-preview-action, and JamesIves/github-pages-deploy-action. Mutable tags can be compromised. Pin to full commit SHA.
Workflow permissions too broad (medium)
preview.yml grants contents: write + pull-requests: write at the workflow level for pull_request trigger. Scope write permissions to only the deploy step to reduce attack surface.
Cross-component image dependency (medium)
Multiple v2 pages (home.adoc, archive-plan.adoc, create-maps.adoc, create-providers.adoc, execute-migration.adoc, verify-migration.adoc, setup-rhdp.adoc) reference images via image::guides:... from the v1 component. If v2 ever ships without v1, all images break. Consider copying images into v2 or documenting the hard dependency.
Nav/file mismatch in roles module (medium)
v2/modules/roles/nav.adoc lists 8 roles, but roles/pages/ contains 26 .adoc files. The 18 stub pages ("not in collection v2") are accessible by direct URL but invisible in navigation. Consider using Antora page-aliases to redirect, or add them under a collapsed nav heading.
Placeholder pages (low)
Three pages include _placeholder.adoc stub text: confirm-openshift-ready, setup-environment, run-a-migration. Track removal before GA.
Orphan page (low)
v2/modules/journey/pages/_fused-migrate.adoc is not referenced in any nav or include.
TLS verification warnings (low)
setup-rhdp.adoc uses oc login --insecure-skip-tls-verify=true and inventory examples use K8S_AUTH_VERIFY_SSL=false. Fine for RHDP lab environments, but consider adding an admonition warning against production use.
|
@shebistar can you convert this to a draft PR so we dont accidentally merge it |
|
Converted to Draft @sabre1041 |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch was successfully deployed
4 participants
No description provided.