Skip to content

Add ci-plus-tools dockerfile#2

Open
Userweiwei wants to merge 9 commits intoredhat-chaos:mainfrom
Userweiwei:weiliu-add-ci-dockerfile
Open

Add ci-plus-tools dockerfile#2
Userweiwei wants to merge 9 commits intoredhat-chaos:mainfrom
Userweiwei:weiliu-add-ci-dockerfile

Conversation

@Userweiwei
Copy link
Copy Markdown
Collaborator

@Userweiwei Userweiwei commented Mar 25, 2026

Related To

CGQE-665: Create the Container Image for ci-tool-plus

Description

This PR adds a dedicated Dockerfile (images/Dockerfile.cli-plus-tools) to build the custom test environment image for our CI jobs

Signed-off-by: Wei Liu <weiliu@redhat.com>
Signed-off-by: Wei Liu <weiliu@redhat.com>
Signed-off-by: Wei Liu <weiliu@redhat.com>
Signed-off-by: Wei Liu <weiliu@redhat.com>
Signed-off-by: Wei Liu <weiliu@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Wei Liu <weiliu@redhat.com>
@Userweiwei Userweiwei force-pushed the weiliu-add-ci-dockerfile branch from 4f3e7c0 to 21a6f61 Compare March 25, 2026 02:04
@Userweiwei Userweiwei marked this pull request as ready for review March 25, 2026 02:07
@Userweiwei Userweiwei changed the title [WIP] Add ci-plus-tools dockerfile Add ci-plus-tools dockerfile Mar 25, 2026
Signed-off-by: Wei Liu <weiliu@redhat.com>
@etirta
Copy link
Copy Markdown
Collaborator

etirta commented Mar 25, 2026

@Userweiwei Please run test and attach to this PR that the Dockerfile can build to a working Container Image. Thx.

@Userweiwei Userweiwei requested a review from etirta March 26, 2026 02:18
@Userweiwei
Copy link
Copy Markdown
Collaborator Author

Userweiwei commented Mar 27, 2026

@Userweiwei Please run test and attach to this PR that the Dockerfile can build to a working Container Image. Thx.
@etirta Seems the job checking had passed, do you mean that I still need to run in local to verify the dockerfile?

@Userweiwei Userweiwei force-pushed the weiliu-add-ci-dockerfile branch from e6a0563 to 0f5cb62 Compare March 27, 2026 06:33
@etirta
Copy link
Copy Markdown
Collaborator

etirta commented Mar 27, 2026

@etirta Seems the job checking had passed, do you mean that I still need to run in local to verify the dockerfile?

Yes, run in your local system using docker build or podman build to locally test the Dockerfile. Replace the FROM with the QCI Proxy. Ask the CI Operator AI tool (Notebook LM) if need help about QCI Proxy.

@Userweiwei Userweiwei force-pushed the weiliu-add-ci-dockerfile branch from 0f5cb62 to 9ba1808 Compare March 28, 2026 00:26
@Userweiwei
Copy link
Copy Markdown
Collaborator Author

Userweiwei commented Mar 28, 2026

@etirta Seems the job checking had passed, do you mean that I still need to run in local to verify the dockerfile?

Yes, run in your local system using docker build or podman build to locally test the Dockerfile. Replace the FROM with the QCI Proxy. Ask the CI Operator AI tool (Notebook LM) if need help about QCI Proxy.
Make small update for the Dockerfile and run in local passed.
[root@cloud-qe-03-vm-09 ~]# podman build -t my-cli-test -f Dockerfile.cli-plus-tools .
STEP 1/2: FROM quay-proxy.ci.openshift.org/openshift/ci:ocp_4.20_cli
STEP 2/2: RUN <<run-EOF (set -exo pipefail; shopt -s inherit_errexit...)
...
Successfully tagged localhost/my-cli-test:latest
8d9958875bd315e7e33a5c73118f8388bfefcc42f0ea57a809fb834e8b6d2f4a
[root@cloud-qe-03-vm-09 ~]# podman run --rm -it my-cli-test /bin/bash
[root@2ed3c551ae9c /]# ssh -V
OpenSSH_8.7p1, OpenSSL 3.0.7 1 Nov 2022
[root@2ed3c551ae9c /]# jq --version
jq-1.6
[root@2ed3c551ae9c /]# yq --version
yq (https://github.com/mikefarah/yq/) version v4.52.5
[root@2ed3c551ae9c /]# virtctl version --client
Client Version: version.Info{GitVersion:"v1.8.0", GitCommit:"85b6a25964132b0d578184598fb3c00d00d71f61", GitTreeState:"clean", BuildDate:"2026-03-24T14:18:44Z", GoVersion:"go1.24.9 X:nocoverageredesign", Compiler:"gc", Platform:"linux/amd64"}

@etirta
Copy link
Copy Markdown
Collaborator

etirta commented Mar 28, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2026
@etirta
Copy link
Copy Markdown
Collaborator

etirta commented Mar 28, 2026

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: etirta, Userweiwei

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etirta
Copy link
Copy Markdown
Collaborator

etirta commented Mar 28, 2026

@Userweiwei, it turns out this repo (aka CI Operator (Test) Component Repo) should have an OWNERS file. This file will be the authority for https://github.com/openshift/release/blob/main/ci-operator/config/redhat-chaos/lp-chaos/OWNERS (future changes must then be done in this repo instead). Please copy that file here and place it in the repo root.

After that, the /approve from anyone listed in the OWNERS file will work. If we don't do this, we have to use standard GitHub approvals; therefore, the process remains disjointed from the rest of the CI Operator Component repositories.

Just to be clear, this only affects and synchronizes with the OWNERS file in the Job Conf. directory. The OWNERS files under the Step Registry are standalone.

@etirta
Copy link
Copy Markdown
Collaborator

etirta commented Mar 28, 2026

@Userweiwei If the OWNERS file is using group aliases (like in https://github.com/RedHatQE/interop-testing/pull/3/changes), it turned out the upstream component repo. (this repo.) also need to have OWNERFILES defining the alias (like in https://github.com/openshift/release/blob/main/OWNERS_ALIASES, but only the used aliases need to be defined). See RedHatQE/interop-testing#3 (comment) for details.

Unfortunately this means we have to maintain the group aliases in multiple places as the one in openshift/release and upstream component repo.s are not synchronized 🤦.

Signed-off-by: Wei Liu <weiliu@redhat.com>
@Userweiwei Userweiwei force-pushed the weiliu-add-ci-dockerfile branch from 9ba1808 to 7b1acee Compare March 30, 2026 00:56
@openshift-ci openshift-ci bot removed the lgtm label Mar 30, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants