Skip to content

Externalize MPC embedded scripts - KFLUXINFRA-4159 Prod - Ring1#13051

Draft
celeztyne wants to merge 1 commit into
redhat-appstudio:mainfrom
celeztyne:KFLUXINFRA-4159-ring1
Draft

Externalize MPC embedded scripts - KFLUXINFRA-4159 Prod - Ring1#13051
celeztyne wants to merge 1 commit into
redhat-appstudio:mainfrom
celeztyne:KFLUXINFRA-4159-ring1

Conversation

@celeztyne

Copy link
Copy Markdown
Contributor

This PR is from #12867 that has been divided in two rings. In this ring1 following production clusters with lower usage are included:

  • kflux-fedora-01
  • kflux-prd-rh03
  • kflux-osp-p01
  • kflux-rhel-p01
  • stone-prod-p01

The kustomization configuration for charts on these clusters are using new {production,production-downstream}/base/host-config-chart/{files,templates}, while other production clusters are still pointing charts config to old/current base in multi-platform-controller/base

If all goes well we implement in ring2 after a week.

Chages here includes correcting bugs, security and some cosmetic/formatting issues.

The most relevant change might be creating the MIME/script cloud-init-userdata.tpl to be used as "template", explanation from Oscar #11239 (comment)

What could go wrong: This change might impact some VMs in production
Rollback plan: Revert the PR and redeploy. No data migration involved.
Testing: PR Validated in staging with no issues (#11858)

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celeztyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Kustomize Render Diff

Comparing 7e9a1ef3c128159d2b

Component Environment Changes
components/multi-platform-controller/production-downstream/kflux-osp-p01 production +2 -73
components/multi-platform-controller/production-downstream/kflux-rhel-p01 production +1 -73
components/multi-platform-controller/production-downstream/stone-prod-p01 production +1 -73
components/multi-platform-controller/production/kflux-fedora-01 production +1 -0
components/multi-platform-controller/production/kflux-prd-rh03 production +1 -73

Total: 5 components, +6 -292 lines

📋 Full diff available in the workflow summary and as a downloadable artifact.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.11%. Comparing base (7e9a1ef) to head (0d7a407).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #13051   +/-   ##
=======================================
  Coverage   57.11%   57.11%           
=======================================
  Files          23       23           
  Lines        1455     1455           
=======================================
  Hits          831      831           
  Misses        548      548           
  Partials       76       76           
Flag Coverage Δ
go 57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant