Externalize MPC embedded scripts - KFLUXINFRA-4159 Prod - Ring1#13051
Externalize MPC embedded scripts - KFLUXINFRA-4159 Prod - Ring1#13051celeztyne wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celeztyne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kustomize Render DiffComparing
Total: 5 components, +6 -292 lines 📋 Full diff available in the workflow summary and as a downloadable artifact. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13051 +/- ##
=======================================
Coverage 57.11% 57.11%
=======================================
Files 23 23
Lines 1455 1455
=======================================
Hits 831 831
Misses 548 548
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This PR is from #12867 that has been divided in two rings. In this ring1 following production clusters with lower usage are included:
The kustomization configuration for charts on these clusters are using new {production,production-downstream}/base/host-config-chart/{files,templates}, while other production clusters are still pointing charts config to old/current base in multi-platform-controller/base
If all goes well we implement in ring2 after a week.
Chages here includes correcting bugs, security and some cosmetic/formatting issues.
The most relevant change might be creating the MIME/script cloud-init-userdata.tpl to be used as "template", explanation from Oscar #11239 (comment)
What could go wrong: This change might impact some VMs in production
Rollback plan: Revert the PR and redeploy. No data migration involved.
Testing: PR Validated in staging with no issues (#11858)