Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable posix fallocate on Android #8062

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

nirinchev
Copy link
Member

What, How & Why?

Fixes #7950

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@nirinchev nirinchev requested a review from fealebenpae January 3, 2025 09:38
@cla-bot cla-bot bot added the cla: yes label Jan 3, 2025
@nirinchev nirinchev requested a review from jedelbo January 3, 2025 09:38
@nirinchev nirinchev mentioned this pull request Jan 3, 2025
4 tasks
@nirinchev nirinchev marked this pull request as ready for review January 3, 2025 16:35
@nirinchev
Copy link
Member Author

The evergreen failure is not caused by these changes.

@nirinchev nirinchev added the no-jira-ticket Skip checking the PR title for Jira reference label Jan 3, 2025
Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fealebenpae what is your verdict on this?

@nirinchev nirinchev merged commit 595cb2e into community Jan 6, 2025
43 of 46 checks passed
@nirinchev nirinchev deleted the ni/no-posix-fallocate branch January 6, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants