Big refactor and various improvements #39
Conversation
|
@alayshahh No idea why the windows stuff isn't working - going to fix that later. But, if you could review the rest of the patch that would be appreciated 👍🏻 |
There was a problem hiding this comment.
couple of unused imports and etc. can clean up later on, once refactor is complete. Colored with windows does not work due to some weird thing w Power Shell/Command Line and using ANSI (I remember this being a big issue when I was working on it).
https://stackoverflow.com/questions/51680709/colored-text-output-in-powershell-console-using-ansi-vt100-codes
|
I'm gonna take a look through https://github.com/nushell/nushell to see how they do it. They support all platforms and get colored output with no issues, by maintaining a modified version of |
Since I haven't worked on this project in a while, I have learned a lot about Rust in the meantime. Going back over this codebase I see lots of bad practices and better ways to do things.
However, I'm not changing any variable names yet or any architectural changes, just refactoring where it is trivial. Also, I am removing logging since we don't need anything that intense, and print statements are more than enough for this application.
Lastly, this patch also is meant to close #1, since I did implement colored output and better output messages. Below is a screenshot
