Migrate website to uv #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
May 28, 2025
| @@ -47,9 +47,15 @@ manually, you can install all package level dependencies with: | |||
|
|
|||
| .. code-block:: console | |||
|
|
|||
| $ poetry install | |||
| $ uv pip install -r requirements.txt | |||
There was a problem hiding this comment.
The two updates in this section seem incorrect. The lockfile is checked in so always will be available, and we don't use the requirements file pattern here either way. Lockfiles are a better solution than requirements files anyways, so I think this can just always be uv sync.
|
|
||
| Using ``asdf`` is recommended but optional. The ``asdf`` commands below will | ||
| install all system level dependencies for you, including Poetry. | ||
| install all system level dependencies for you, including Python and Node.js. |
There was a problem hiding this comment.
asdf supports uv as well, so no need to special case that here.
Suggested change
| install all system level dependencies for you, including Python and Node.js. | |
| install all system level dependencies for you. |
| @@ -1,3 +1,2 @@ | |||
| nodejs 14.21.1 | |||
| python 3.10.8 | |||
There was a problem hiding this comment.
uv is supported by asdf
Suggested change
| python 3.10.8 | |
| python 3.10.8 | |
| uv 0.7.8 |
| built using a number of Node dependencies. | ||
|
|
||
| You will need the following requirements: | ||
|
|
||
| * Node.js version ``14`` | ||
| * Python version ``3.10`` (any release ``>=3.6`` works) | ||
| * Poetry version ``1.2`` (any release ``>=1.1`` works) | ||
| * uv (see https://github.com/astral-sh/uv for installation instructions) |
There was a problem hiding this comment.
Suggested change
| * uv (see https://github.com/astral-sh/uv for installation instructions) | |
| * uv (Use ``asdf`` or see https://github.com/astral-sh/uv for installation instructions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://readthedocs-about--359.org.readthedocs.build/