-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
APIv3: proxy these URLs to be served from El Proxito /_/api/v3/
#11831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b60813e
fac75b3
3306c4d
cd5b0e6
3c582ba
ba741e2
3be7a0c
fefe902
76e4fc4
2e0f9f9
c73ff65
5584ca3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,7 @@ class Meta: | |
fields = [ | ||
"verbose_name", | ||
"privacy_level", | ||
"hidden", | ||
"active", | ||
"built", | ||
"uploaded", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,9 +10,12 @@ | |
from readthedocs.api.v3.proxied_views import ProxiedEmbedAPI | ||
from readthedocs.search.api.v3.views import ProxiedSearchAPI | ||
|
||
from .urls import router | ||
|
||
api_proxied_urls = [ | ||
path("embed/", ProxiedEmbedAPI.as_view(), name="embed_api_v3"), | ||
path("search/", ProxiedSearchAPI.as_view(), name="search_api_v3"), | ||
] | ||
|
||
urlpatterns = api_proxied_urls | ||
urlpatterns += router.urls | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are proxying the whole API here instead of what addons needs, this has several implications:
I'd suggest we explicitly bring what we need and adapt it to work under proxito (as we have done with search and embed APIs) instead of trying to bring the whole API v3 at once. For example, we don't need to list all projects from docs pages, or redirects. |
Uh oh!
There was an error while loading. Please reload this page.