GitHub App: open beta #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
approved these changes
May 28, 2025
readthedocsext/theme/templates/profiles/partials/github_oauth_disconnect_list.html
Outdated
Show resolved
Hide resolved
readthedocsext/theme/templates/profiles/partials/github_oauth_revoke_list.html
Outdated
Show resolved
Hide resolved
|
|
|
Ahh okay, so yeah there's more conflicting content on that page that we should disable. The UX will be confusing with just the buttons disabled and there is a lot of text on the page that will make the warning hard to notice, including conflicting warnings. I'd wrap everything below the "We don't recommend" warning with a |
|
Like this? |
|
Yeah, that looks great and definitely makes it clearer what is happening. Users can sort of get the preview of what will happen when it is usable too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revoke and disconnect options are not available during the beta, so users can use the old button to log in without any problems. They can still do this from the social accounts list, but if they do so, next time they log in will be redirected to the correct login page, so.
Ref https://github.com/readthedocs/meta/issues/187