Skip to content

Don't set multiple event listeners #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't set multiple event listeners #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/linkpreviews.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,11 @@ function setupTooltip(el, doctoolname, doctoolversion, selector) {
const anchorElement = el;
let relatedTooltip;

el.addEventListener("mouseenter", delayShowTooltip);
el.addEventListener("mouseleave", delayHideTooltip);
if (!el.hasEventListener) {
el.addEventListener("mouseenter", delayShowTooltip);
el.addEventListener("mouseleave", delayHideTooltip);
el.hasEventListener = true;
}

let showTooltipTimeoutId = null;
let hideTooltipTimeoutId = null;
Expand Down Expand Up @@ -153,7 +156,8 @@ function setupTooltip(el, doctoolname, doctoolversion, selector) {
return relatedTooltip;
}

const existingTooltip = anchorElement.parentElement.querySelector(
// Check if there is already a tooltip for this url
const existingTooltip = document.querySelector(
`div[${TOOLTIP_DATA_HREF}="${anchorElement.href}"]`,
);
if (existingTooltip) {
Expand All @@ -171,8 +175,11 @@ function setupTooltip(el, doctoolname, doctoolversion, selector) {
anchorElement.insertAdjacentElement("afterend", newTooltip);
// Let's add event listeners on the tooltip as well, to prevent hiding, when
// mouse moves away from the anchor element
newTooltip.addEventListener("mouseenter", cancelHideDelay);
newTooltip.addEventListener("mouseleave", delayHideTooltip);
if (!newTooltip.hasEventListener) {
newTooltip.addEventListener("mouseenter", cancelHideDelay);
newTooltip.addEventListener("mouseleave", delayHideTooltip);
newTooltip.hasEventListener = true;
}
relatedTooltip = newTooltip;
return newTooltip;
}
Expand Down