Skip to content

Flyout: promote beta dashboard from it #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2024
Merged

Flyout: promote beta dashboard from it #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
202285a
Flyout: promote beta dashboard from it
humitos May 23, 2024
e3e946b
Use `app.` instead of `beta.`
humitos May 24, 2024
d11c28c
Merge branch 'main' of github.com:readthedocs/addons into humitos/fly…
humitos May 24, 2024
0abc1d5
Merge branch 'main' of github.com:readthedocs/addons into humitos/fly…
humitos May 28, 2024
a83121f
Merge branch 'main' of github.com:readthedocs/addons into humitos/fly…
humitos May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/readthedocs-addons.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/readthedocs-addons.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 9 additions & 3 deletions src/flyout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ export class FlyoutElement extends LitElement {
<dd>
<a
href="${addUtmParameters(
this.config.projects.current.urls.home,
this.config.projects.current.urls.home
.replace("readthedocs.org", "beta.readthedocs.org")
.replace("readthedocs.com", "beta.readthedocs.com"),
"flyout",
)}"
>Project Home</a
Expand All @@ -181,7 +183,9 @@ export class FlyoutElement extends LitElement {
<dd>
<a
href="${addUtmParameters(
this.config.projects.current.urls.builds,
this.config.projects.current.urls.builds
.replace("readthedocs.org", "beta.readthedocs.org")
.replace("readthedocs.com", "beta.readthedocs.com"),
"flyout",
)}"
>Builds</a
Expand All @@ -190,7 +194,9 @@ export class FlyoutElement extends LitElement {
<dd>
<a
href="${addUtmParameters(
this.config.projects.current.urls.downloads,
this.config.projects.current.urls.downloads
.replace("readthedocs.org", "beta.readthedocs.org")
.replace("readthedocs.com", "beta.readthedocs.com"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This view does now currently exist on the new dashboard. See readthedocs/ext-theme#77

It isn't completely useless, but this view is not linked and was never styled:

https://beta.readthedocs.org/projects/docs/downloads/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should remove the "Downloads" link from the flyout?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably should drop the link to the downloads view. The downloadable formats are already listed in the flyout already, so it does seem redundant already. If users are using the downloads link we can reconsider whether we use the view or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this link in #322

"flyout",
)}"
>Downloads</a
Expand Down
12 changes: 6 additions & 6 deletions tests/__snapshots__/flyout.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@ snapshots["Flyout addon snapshot flyout completely"] =
On Read the Docs
</dt>
<dd>
<a href="https://readthedocs.org/projects/project/?utm_source=project&amp;utm_content=flyout">
<a href="https://beta.readthedocs.org/projects/project/?utm_source=project&amp;utm_content=flyout">
Project Home
</a>
</dd>
<dd>
<a href="https://readthedocs.org/projects/project/builds/?utm_source=project&amp;utm_content=flyout">
<a href="https://beta.readthedocs.org/projects/project/builds/?utm_source=project&amp;utm_content=flyout">
Builds
</a>
</dd>
<dd>
<a href="https://readthedocs.org/projects/project/downloads/?utm_source=project&amp;utm_content=flyout">
<a href="https://beta.readthedocs.org/projects/project/downloads/?utm_source=project&amp;utm_content=flyout">
Downloads
</a>
</dd>
Expand Down Expand Up @@ -179,17 +179,17 @@ snapshots["Flyout addon snapshot flyout with search disabled"] =
On Read the Docs
</dt>
<dd>
<a href="https://readthedocs.org/projects/project/?utm_source=project&amp;utm_content=flyout">
<a href="https://beta.readthedocs.org/projects/project/?utm_source=project&amp;utm_content=flyout">
Project Home
</a>
</dd>
<dd>
<a href="https://readthedocs.org/projects/project/builds/?utm_source=project&amp;utm_content=flyout">
<a href="https://beta.readthedocs.org/projects/project/builds/?utm_source=project&amp;utm_content=flyout">
Builds
</a>
</dd>
<dd>
<a href="https://readthedocs.org/projects/project/downloads/?utm_source=project&amp;utm_content=flyout">
<a href="https://beta.readthedocs.org/projects/project/downloads/?utm_source=project&amp;utm_content=flyout">
Downloads
</a>
</dd>
Expand Down
6 changes: 3 additions & 3 deletions tests/flyout.test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,13 @@
<dl>
<dt>On Read the Docs</dt>
<dd>
<a href="https://readthedocs.org/projects/project/?utm_source=project&amp;utm_content=flyout">Project Home</a>
<a href="https://beta.readthedocs.org/projects/project/?utm_source=project&amp;utm_content=flyout">Project Home</a>
</dd>
<dd>
<a href="https://readthedocs.org/projects/project/builds/?utm_source=project&amp;utm_content=flyout">Builds</a>
<a href="https://beta.readthedocs.org/projects/project/builds/?utm_source=project&amp;utm_content=flyout">Builds</a>
</dd>
<dd>
<a href="https://readthedocs.org/projects/project/downloads/?utm_source=project&amp;utm_content=flyout">Downloads</a>
<a href="https://beta.readthedocs.org/projects/project/downloads/?utm_source=project&amp;utm_content=flyout">Downloads</a>
</dd>
</dl>
`);
Expand Down