fix action pattern in useTransition / useOptimistic #7796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a function with the
action
suffix, it's because you know that it's being called inside of a transition. So it doesn't really make sense to immediately wrap the body of a function namedsendMessageAction
withstartTransition
.The reason the
useOptimistic
example did this is because the childThread
component was not awaiting theaction
prop that was passed in, but the pattern should really be that you await theaction
prop if you expose it. That allows theaction
callback to be either synchronous or asynchronous without requiring an additionalstartTransition
to wrap theawait
in the action.