Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Fixing typo in first webpack.config.js #290

Closed
wants to merge 1 commit into from
Closed

Fixing typo in first webpack.config.js #290

wants to merge 1 commit into from

Conversation

ww2
Copy link

@ww2 ww2 commented Feb 10, 2017

The first example webpack.config.js has the publicPath set to '/' and the path set to 'public'; since Express hasn't yet been configured to serve files from 'public', that configuration prevents Express from serving index.html (which hasn't been moved yet). Changing path to '' in that example fixes the issue at that point.

The first example webpack.config.js has the publicPath set to '/' and the path set to 'public'; since Express hasn't yet been configured to serve files from 'public', that configuration prevents Express from serving index.html (which hasn't been moved yet).  Changing path to '' in that example fixes the issue at that point.
@merriam
Copy link

merriam commented Mar 21, 2017

This another fix to #218, for which a good solution might be not asking the user to modify the webpack.config.js file at all until after the first production server run. I recommend closing this PR. See #310.

@ww2 ww2 closed this Jan 29, 2018
@ww2 ww2 deleted the patch-1 branch January 29, 2018 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants