-
Notifications
You must be signed in to change notification settings - Fork 54
Learn / Referencing Values with Refs #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learn / Referencing Values with Refs #511
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
9c7a5f3
to
4c78e8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general very fast and very good translation! Nice start! 🚀
There are minor things to correct, nothing serious. Don't be scared about number of suggestions. I have a keen eye for details. This is nothing personal 😉
Thanks for the extensive feedback! I missed quite a few things, especially regarding the impersonal form of verbs. Your feedback also answers many of the questions that I had during the translation process. I'll apply the feedback in the next few days and will mention you once the changes have been implemented. I also have a quick question about resolving conversations: what's the preferred approach on this repository? Should the reviewer resolve them, or the person who implements the fixes 🤔? |
That's the spirit! 🔥 I am not aware of any specific way of working in this project regarding resolving conversations, but I would say that if you simply agree with suggestion or fix is very simple and it can be done in one way only, you can apply it and resolve. I think this will be 95% of cases. You can left conversation open in rare cases when change can be done in couple of ways and you are not sure how it will be received by the reviewer. |
Hey @dawidsabat, |
c97c11f
to
4bdcd85
Compare
4bdcd85
to
2b9c3a5
Compare
Great! I will review it tomorrow. |
2b9c3a5
to
734df38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Last issues to fix and we are go for merge 😉
734df38
to
3af8233
Compare
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine, good job! 🚀
Translation of the page Learn / Escape Hatches / Referencing Values with Refs into 🇵🇱 .
Note
This is my first translation, any feedback or suggestions for improvement would be greatly appreciated 😉