This repository has been archived by the owner on Nov 26, 2019. It is now read-only.
Try to setup react-native-screens #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/screens
branch
4 times, most recently
from
49db3c8 to
6694a61
Compare
satya164
force-pushed
the
master
branch
8 times, most recently
from
9db82ec to
b57666d
Compare
This seems super-buggy atm. On Android, initially this seems to work, but as soon as you start swiping and then release, no gestures such as touch work after that. Same issue can also be reproduced if you just leave all screens active. Seems to be software-mansion/react-native-screens#61 On iOS, I get `undefined is not an object (evaluating 'this._ref.setNativeProps')`. The `ref` is undefined for some reason only on iOS: https://github.com/kmagiera/react-native-screens/blob/acf80e640c584bf4019cfaf9356ee44b09e7dc99/src/screens.native.js#L44 If you do `active={focused ? 1 : 0}`, it works as expected on Android (though not desirable). However, on iOS, no gestures such as touch seem to work.
satya164
force-pushed
the
@satya164/screens
branch
from
6694a61 to
7bc1922
Compare
satya164
force-pushed
the
master
branch
2 times, most recently
from
5cfceef to
9c1ebdf
Compare
7 tasks
osdnk
reviewed
Jun 13, 2019
| @@ -1,5 +1,6 @@ | |||
| import * as React from 'react'; | |||
| import { View, StyleSheet, LayoutChangeEvent } from 'react-native'; | |||
| import { StyleSheet, LayoutChangeEvent, ViewProps } from 'react-native'; | |||
| import { Screen, ScreenContainer } from 'react-native-screens'; | |||
There was a problem hiding this comment.
Suggested change
| import { Screen, ScreenContainer } from 'react-native-screens'; | |
| import { Screen, ScreenContainer, NativeScreen } from 'react-native-screens'; |
|
|
||
| // @ts-ignore | ||
| const AnimatedScreen = Animated.createAnimatedComponent( | ||
| Screen |
There was a problem hiding this comment.
Suggested change
| Screen | |
| NativeScreen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems super-buggy atm.
On Android, initially this seems to work, but as soon as you start swiping and then release, no gestures such as touch work after that.
Same issue can also be reproduced if you just leave all screens active. Seems to be software-mansion/react-native-screens#61
On iOS, I get
undefined is not an object (evaluating 'this._ref.setNativeProps').The
refis undefined for some reason only on iOS: https://github.com/kmagiera/react-native-screens/blob/acf80e640c584bf4019cfaf9356ee44b09e7dc99/src/screens.native.js#L44If you do
active={focused ? 1 : 0}, it works as expected on Android (though not desirable). However, on iOS, no gestures such as touch seem to work.cc @brentvatne @osdnk @kmagiera