Prop for alerting the user before exiting app #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
? |
|
Thank you @nmquebb, I'll review this soon. |
charpeni
requested changes
Mar 12, 2017
There was a problem hiding this comment.
Thank you for your contribution and sorry for the delay.
The back button will only exit the current application if it's the last route in the stack, it's the expected behaviour.
However, it could be nice to have this, but I would highly prefer a callback or something more customizable than a hardcoded alert that can't be translated.
| @@ -17,6 +18,7 @@ const propTypes = { | |||
| currentRoute: PropTypes.object.isRequired, | |||
| customAction: PropTypes.func, | |||
| handleBackAndroid: PropTypes.bool, | |||
| alertAndroidExit: PropTypes.bool, | |||
| @@ -70,10 +72,19 @@ class NavBarContainer extends React.Component { | |||
| BackAndroid.addEventListener('hardwareBackPress', () => { | |||
| if (this.props.currentRoute.index > 0) { | |||
| this.goBack(); | |||
| return true; | |||
| } else { | |||
| console.log('dsa') | |||
There was a problem hiding this comment.
These console.log should not be commited.
| @@ -23,6 +23,7 @@ const propTypes = { | |||
| customAction: PropTypes.func, | |||
| firstRoute: PropTypes.object.isRequired, | |||
| handleBackAndroid: PropTypes.bool, | |||
| alertAndroidExit: PropTypes.bool, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been getting some complaints from user's about the app just exiting. I'm not an Android user so I don't know if that's expected behavior or not, but I thought it would be nice to add an option alert before leaving the app.