-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topics and make searching by topics simpler #300
base: main
Are you sure you want to change the base?
Conversation
hello! thanks for the pr! after seeing this in the ui i'm not totally sure we want it to be featured so prominently. i'll defer to @jonsamp for design ideas here. also, i noticed that we're already factoring in topics when you search, so that's nice! the ui is the only remaining bit |
Haha, fair enough. I thought the page could use some colors but I am open to changing whatever. I was also considering using icons for the platforms but I didn't know what to use for MacOS. 🤔 |
Another thing to consider for these tags - currently we're just using "topics" from GitHub, but this doesn't work too well in some situations, eg: if a library is inside of a monorepo, it can't have its own topics. So we should maybe use npm keywords in addition to GitHub topics and |
I'd be open to that. Are we already fetching that information? |
not yet - we're just fetching download stats from npm: https://github.com/react-native-community/directory/blob/master/scripts/fetch-npm-data.js |
Ooh, I like that. I'll try to update and push this over the weekend! |
lovely @jonsamp! |
I have displayed the topics associated with each library and also made them clickable. This way, whenever a user clicks a topic, they can search by that specific topic.
I also created a small demo to see the feature in action.