-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fire OS compatibility #1438
base: main
Are you sure you want to change the base?
Conversation
1086ce1
to
01e8823
Compare
Co-authored with @chris-trag and @giolaq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inserted β
per warning
Hey @mosesroth, thanks for working on this addition! I would like to ask few questions before we can proceed. About which Fire OS we are talking about, is it the Android TV fork? Or this is about the new, proprietary Linux-based OS announced earlier this year? |
Hi @Simek , yes Fire OS is the Android fork mentioned on the doc you linked, which is what we tested on. Thanks, Moses |
Thanks for the clarification Moses! π We were discussing this addition internally, and with AFAIK when it comes to Android TV, all libraries marked with Android or tvOS support should be working fine on Android TV (so also on Fire OS) devices, since most of the code is shared with Android mobile platform. You can check the RN tvOS readme for a bit more details on that topic: This is also a take that the Fire OS page I have linked previously stand by:
If there are something that we miss, any concerns about compatibility or important differences between regular Android TV and Fire OS please let us know. We are happy to learn more about TV apps ecosystem, and work on clarifying the state of libraries support for different TV targets. |
Hi @Simek , Fire OS runs on Fire tablets too, not just Fire TVs. It is based on Android, but there can be some inconsistencies, not all Android libraries will work on FOS. For example, if a library requires Google Play Services, it won't work on FOS, because those aren't present on Fire devices. |
π Why & how
This PR adds Fire OS compatibility as an option to the directory and includes 45 libraries that have been tested and confirmed compatible with Fire OS.
β Checklist
react-native-libraries.json
react-native-libraries.json