fix(android): hardcoded appName when finding build.gradle #2652
+40
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
approved these changes
Apr 16, 2025
cortinico
approved these changes
Apr 16, 2025
thymikee
added a commit
that referenced
this pull request
Apr 17, 2025
* fix(android): hardcoded appName when finding build.gradle * add extra tests * update snapshot * update expectation to reflect error change * Revert "update expectation to reflect error change" This reverts commit c45afea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not all apps have
appdir and we already have a config for that, which was not used by thefindBuildGradlehelper.Closes #2524
Closes #2516
Test Plan
Updated tests
Checklist
react-nativecheckout (instructions).