feat: look for Podfile in the source directory too #1445
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm adding React Native to an existing native project. The project is fairly large, so it is split up into multiple subprojects and does not follow the typical React Native directory structure. Instead this is how it is setup:
Currently,
cli
assumes thatPodfile
is a sibling ofProject.xcodeproj
. This change adds a feature enabling it to look for thePodfile
from the source directory, if it is not found in the project directory.Test Plan:
yarn react-native config
, thePodfile
configuration value is no longernull
.yarn react-native run-ios
no longer throws the following error: