Skip to content

feat: look for Podfile in the source directory too #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Kiesco08
Copy link

Summary:

I'm adding React Native to an existing native project. The project is fairly large, so it is split up into multiple subprojects and does not follow the typical React Native directory structure. Instead this is how it is setup:

ios/
| | | |_ Pods/
| | |__ **Podfile**
| |___ Project/Project.xcodeproj/
|____ ProjectReactNativeFramework/

... // Other subprojects

Currently, cli assumes that Podfile is a sibling of Project.xcodeproj. This change adds a feature enabling it to look for the Podfile from the source directory, if it is not found in the project directory.

Test Plan:

  • When I run yarn react-native config, the Podfile configuration value is no longer null.
  • Running yarn react-native run-ios no longer throws the following error:
error Could not find "Podfile.lock" at null.lock. Did you run "pod install" in iOS directory?

@Kiesco08
Copy link
Author

This test passes locally 🤔

@grabbou
Copy link
Member

grabbou commented Jul 15, 2021

Related to #1444 too. I will work on both of these PRs tomorrow and merge one of them (not sure which one tho) in order to resolve this issue.

@grabbou
Copy link
Member

grabbou commented Aug 4, 2021

Closing in favour of #1459, I would prefer to allow users to set the path manually, rather than extending the automatic detection (it's there to satisfy 99% of standard use cases)

@grabbou grabbou closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants