fix: upload drag directory can not work #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zombieJ
reviewed
Aug 1, 2024
| @@ -76,11 +76,11 @@ class AjaxUploader extends Component<UploadProps> { | |||
| } | |||
|
|
|||
| if (this.props.directory) { | |||
| traverseFileTree( | |||
| const files = await traverseFileTree( | |||
zombieJ
reviewed
Aug 7, 2024
src/traverseFileTree.ts
Outdated
| } | ||
| while (true) { | ||
| const results = await new Promise<InternalDataTransferItem[]>((resolve, reject) => { | ||
| dirReader.readEntries(resolve, reject); |
There was a problem hiding this comment.
按照原本的逻辑，失败了就直接无视了。这里加了 reject 后，没有做错误处理，await 后会直接挂掉。
There was a problem hiding this comment.
@zombieJ 更新了下这块的处理，看看有没有问题
zombieJ
reviewed
Aug 7, 2024
src/traverseFileTree.ts
Outdated
| break; | ||
| } | ||
|
|
||
| for (const entry of results) { |
There was a problem hiding this comment.
这个换一下 for (let i ...)，IE 11 不支持 of loop
zombieJ
approved these changes
Aug 13, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#50080
upload/src/traverseFileTree.ts
Lines 20 to 31 in 80e5228
出现这个bug的原因大概率是因为异步api导致，
dirReader.readEntries是异步且被递归调用，walkFiles这个方法又是同步执行的，while循环结束了一会之后才会走入readEntries的回调，导致callback其实是提前拿了一个空数组就提前结束。