Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:delay folder upload until all children files are parsed when drag #561

Merged
merged 8 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions src/traverseFileTree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,33 +10,36 @@ interface InternalDataTransferItem extends DataTransferItem {
path: string;
}

function loopFiles(item: InternalDataTransferItem, callback) {
const dirReader = item.createReader();
let fileList = [];

function sequence() {
dirReader.readEntries((entries: InternalDataTransferItem[]) => {
const entryList = Array.prototype.slice.apply(entries);
fileList = fileList.concat(entryList);
const traverseFileTree = (files: InternalDataTransferItem[], callback, isAccepted) => {
let restFile = files.length;
zombieJ marked this conversation as resolved.
Show resolved Hide resolved
const flattenFileList = [];
function loopFiles(item: InternalDataTransferItem, InnerCallback) {
const dirReader = item.createReader();
let fileList = [];

// Check if all the file has been viewed
const isFinished = !entryList.length;
function sequence() {
dirReader.readEntries((entries: InternalDataTransferItem[]) => {
zombieJ marked this conversation as resolved.
Show resolved Hide resolved
const entryList = Array.prototype.slice.apply(entries);
fileList = fileList.concat(entryList);

if (isFinished) {
callback(fileList);
} else {
sequence();
}
});
}
// Check if all the file has been viewed
const isFinished = !entryList.length;

sequence();
}
if (isFinished) {
restFile = restFile - 1 + fileList.length;
InnerCallback(fileList);
} else {
sequence();
}
});
}

const traverseFileTree = (files: InternalDataTransferItem[], callback, isAccepted) => {
sequence();
}
// eslint-disable-next-line @typescript-eslint/naming-convention
const _traverseFileTree = (item: InternalDataTransferItem, path?: string) => {
if (!item) {
zombieJ marked this conversation as resolved.
Show resolved Hide resolved
restFile = restFile - 1;
return;
}
// eslint-disable-next-line no-param-reassign
Expand All @@ -59,7 +62,11 @@ const traverseFileTree = (files: InternalDataTransferItem[], callback, isAccepte
},
});
}
callback([file]);
flattenFileList.push(file);
restFile = restFile - 1;
if (restFile === 0) {
callback(flattenFileList);
}
}
});
} else if (item.isDirectory) {
Expand Down
51 changes: 50 additions & 1 deletion tests/uploader.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const makeFileSystemEntry = item => {
return {
readEntries(handle) {
if (!first) {
return [];
return handle([]);
}

first = false;
Expand Down Expand Up @@ -373,7 +373,56 @@ describe('uploader', () => {
beforeEach(() => {
uploader = render(<Upload {...props} />);
});
it('beforeUpload should run after all children files are parsed', done => {
const props = { action: '/test', directory: true, accept: '.png' };
const mockBeforeUpload = jest.fn();
const beforeUpload = (file, fileList) => {
console.log('beforeUpload', file, fileList);
mockBeforeUpload(file, fileList);
};
const Test = () => {
return <Upload {...props} beforeUpload={beforeUpload} />;
};

const { container } = render(<Test />);
const files = {
name: 'foo',
children: [
{
name: 'bar',
children: [
{
name: '1.png',
},
{
name: '2.png',
},
{
name: 'rc',
children: [
{
name: '3.png',
},
{
name: '4.png',
},
],
},
],
},
],
};
const input = container.querySelector('input')!;
fireEvent.drop(input, { dataTransfer: { items: [makeDataTransferItem(files)] } });
setTimeout(() => {
expect(mockBeforeUpload.mock.calls.length).toBe(4);
expect(mockBeforeUpload.mock.calls[0][1].length).toBe(4);
expect(mockBeforeUpload.mock.calls[1][1].length).toBe(4);
expect(mockBeforeUpload.mock.calls[2][1].length).toBe(4);
expect(mockBeforeUpload.mock.calls[3][1].length).toBe(4);
done();
}, 100);
});
it('unaccepted type files to upload will not trigger onStart', done => {
const input = uploader.container.querySelector('input')!;
const files = {
Expand Down
Loading