feat: retire deprecated api #768
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
概述步骤说明本次变更主要涉及标签页（Tabs）组件的重构，移除了与 变更
诗歌
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/TabNavList/Wrapper.tsx (1)
11-13: 建议添加函数文档注释虽然实现逻辑变得更简洁了，但建议为组件添加 JSDoc 注释，说明：
- renderTabBar 属性的用途
- 移除 panes 支持的原因
- 新的使用方式示例
建议添加如下文档：
+/** + * TabNavList 的包装组件，用于支持自定义渲染 tabBar + * @param renderTabBar - 自定义渲染函数，不再支持 panes 属性 + * @param restProps - 传递给 TabNavList 的其他属性 + */ const TabNavListWrapper: React.FC<TabNavListWrapperProps> = ({ renderTabBar, ...restProps }) => {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
docs/demo/renderTabBar-use-panes.md(0 hunks)docs/examples/renderTabBar-use-panes.tsx(0 hunks)src/TabNavList/Wrapper.tsx(1 hunks)src/Tabs.tsx(0 hunks)src/interface.ts(0 hunks)tests/index.test.tsx(0 hunks)
💤 Files with no reviewable changes (5)
- docs/demo/renderTabBar-use-panes.md
- tests/index.test.tsx
- src/interface.ts
- docs/examples/renderTabBar-use-panes.tsx
- src/Tabs.tsx
🔇 Additional comments (2)
src/TabNavList/Wrapper.tsx (2)
6-8: 类型定义清晰且合理！类型定义使用了 TypeScript 的工具类型，很好地处理了必需和可选属性的关系。
Line range hint
18-20: 开发模式下的命名设置得当！为组件设置 displayName 有助于调试和开发体验，这是一个很好的实践。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 98.96% 98.96% -0.01%
==========================================
Files 18 18
Lines 774 771 -3
Branches 224 227 +3
==========================================
- Hits 766 763 -3
Misses 8 8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
文档更新
renderTabBar相关的文档和示例文件接口变更
TabsProps中的onNextClick、onPrevClick和keyboard属性TabsProps中新增type属性RenderTabBarProps接口中的panes属性测试调整
renderTabBar相关的测试用例重构
TabNavListWrapper组件的渲染逻辑panes相关的代码支持