Skip to content

Commit

Permalink
test: fix test case (#383)
Browse files Browse the repository at this point in the history
  • Loading branch information
zombieJ authored May 8, 2021
1 parent 4adfc91 commit 8e4c8f9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 22 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"@babel/runtime": "^7.11.2",
"classnames": "2.x",
"rc-dropdown": "^3.1.3",
"rc-menu": "^8.6.1",
"rc-menu": "^9.0.0-alpha.7",
"rc-resize-observer": "^1.0.0",
"rc-util": "^5.5.0"
},
Expand Down
29 changes: 8 additions & 21 deletions tests/overflow.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ describe('Tabs.Overflow', () => {
document.body.appendChild(holder);

function btnOffsetPosition() {
// eslint-disable-next-line @typescript-eslint/no-invalid-this
const btn = this as HTMLButtonElement;
const btnList = [...btn.parentNode.childNodes].filter(ele =>
const btnList = Array.from(btn.parentNode.childNodes).filter((ele) =>
(ele as HTMLElement).className.includes('rc-tabs-tab'),
);
const index = btnList.indexOf(btn);
Expand Down Expand Up @@ -69,26 +70,18 @@ describe('Tabs.Overflow', () => {
wrapper.find('.rc-tabs-nav-more').simulate('mouseenter');
jest.runAllTimers();
wrapper.update();
expect(
wrapper
.find('.rc-tabs-dropdown li')
.first()
.text(),
).toEqual('cute');
expect(wrapper.find('.rc-tabs-dropdown li').first().text()).toEqual('cute');

// Click to select
wrapper
.find('.rc-tabs-dropdown-menu-item')
.first()
.simulate('click');
wrapper.find('.rc-tabs-dropdown-menu-item').first().simulate('click');
expect(onChange).toHaveBeenCalledWith('cute');

wrapper.unmount();

jest.useRealTimers();
});

[KeyCode.SPACE, KeyCode.ENTER].forEach(code => {
[KeyCode.SPACE, KeyCode.ENTER].forEach((code) => {
it(`keyboard with select keycode: ${code}`, () => {
jest.useFakeTimers();
const onChange = jest.fn();
Expand All @@ -110,7 +103,7 @@ describe('Tabs.Overflow', () => {
wrapper.find('.rc-tabs-nav-more').simulate('keydown', {
which,
});
expect(wrapper.find('.rc-tabs-dropdown-menu-item-selected').text()).toEqual(match);
expect(wrapper.find('li.rc-tabs-dropdown-menu-item-selected').text()).toEqual(match);
}

keyMatch(KeyCode.DOWN, 'cute');
Expand All @@ -129,10 +122,7 @@ describe('Tabs.Overflow', () => {
});
wrapper.update();
expect(
wrapper
.find('.rc-tabs-dropdown')
.last()
.hasClass('rc-tabs-dropdown-hidden'),
wrapper.find('.rc-tabs-dropdown').last().hasClass('rc-tabs-dropdown-hidden'),
).toBeFalsy();

// ESC
Expand All @@ -141,10 +131,7 @@ describe('Tabs.Overflow', () => {
});
wrapper.update();
expect(
wrapper
.find('.rc-tabs-dropdown')
.last()
.hasClass('rc-tabs-dropdown-hidden'),
wrapper.find('.rc-tabs-dropdown').last().hasClass('rc-tabs-dropdown-hidden'),
).toBeTruthy();

wrapper.unmount();
Expand Down

1 comment on commit 8e4c8f9

@vercel
Copy link

@vercel vercel bot commented on 8e4c8f9 May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.