refactor: rename onCalendarChange to onSelect

react-component · Dec 8, 2023 · af4707a · af4707a
1 parent a7899be
commit af4707a
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/src/NewPicker/PickerPanel/index.tsx b/src/NewPicker/PickerPanel/index.tsx
@@ -179,22 +179,14 @@ function PickerPanel<DateType = any>(
   // >>> CalendarValue
   // CalendarValue is a temp value for user operation
   // which will only trigger `onCalendarChange` but not `onChange`
-  const [calendarValue, setCalendarValue] = React.useState(mergedValue);
-  const updateCalendarValue = (newDate: DateType) => {
-    setCalendarValue(newDate);
-
+  const onInternalSelect = (newDate: DateType) => {
     onSelect?.(newDate);
 
     if (mergedMode === picker) {
-      // setMergedValue(newDate);
       triggerChange(newDate);
     }
   };
 
-  React.useEffect(() => {
-    setCalendarValue(mergedValue);
-  }, [mergedValue]);
-
   // >>> PickerValue
   // PickerValue is used to control the current displaying panel
   const [mergedPickerValue, setInternalPickerValue] = useMergedState(
@@ -221,7 +213,7 @@ function PickerPanel<DateType = any>(
   };
 
   const onPanelValueChange = (newVal: DateType) => {
-    updateCalendarValue(newVal);
+    onInternalSelect(newVal);
     setPickerValue(newVal);
 
     // Update mode if needed
@@ -285,7 +277,7 @@ function PickerPanel<DateType = any>(
         // Value
         pickerValue={mergedPickerValue}
         onPickerValueChange={setPickerValue}
-        value={calendarValue}
+        value={mergedValue}
         onChange={onPanelValueChange}
         // Render
         cellRender={cellRender}