warning if is invalidate date type

react-component · Nov 30, 2019 · 793c523 · 793c523 · vercel · Nov 30, 2019
1 parent bf70725
commit 793c523
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 0 deletions.
diff --git a/src/PickerPanel.tsx b/src/PickerPanel.tsx
@@ -118,6 +118,18 @@ function PickerPanel<DateType>(props: PickerPanelProps<DateType>) {
     onMouseDown,
   } = props as MergedPickerPanelProps<DateType>;
 
+  if (process.env.NODE_ENV !== 'production') {
+    warning(
+      !value || generateConfig.isValidate(value),
+      'Invalidate date pass to `value`.',
+    );
+    warning(
+      !value || generateConfig.isValidate(value),
+      'Invalidate date pass to `defaultValue`.',
+    );
+  }
+
+  // ============================ State =============================
   const { operationRef, panelRef: panelDivRef } = React.useContext(
     PanelContext,
   );

diff --git a/src/generate/index.ts b/src/generate/index.ts
@@ -22,6 +22,7 @@ export interface GenerateConfig<DateType> {
 
   // Compare
   isAfter: (date1: DateType, date2: DateType) => boolean;
+  isValidate: (date: DateType) => boolean;
 
   locale: {
     getWeekFirstDay: (locale: string) => number;

diff --git a/src/generate/moment.ts b/src/generate/moment.ts
@@ -62,6 +62,7 @@ const generateConfig: GenerateConfig<Moment> = {
 
   // Compare
   isAfter: (date1, date2) => date1.isAfter(date2),
+  isValidate: date => date.isValid(),
 
   locale: {
     getWeekFirstDay: locale => {

diff --git a/tests/panel.spec.tsx b/tests/panel.spec.tsx
@@ -1,5 +1,7 @@
 import React from 'react';
 import MockDate from 'mockdate';
+import moment from 'moment';
+import { resetWarned } from 'rc-util/lib/warning';
 import { spyElementPrototypes } from 'rc-util/lib/test/domHook';
 import { mount, getMoment, isSame, MomentPickerPanel } from './util/commonUtil';
 
@@ -369,4 +371,22 @@ describe('Panel', () => {
 
     expect(wrapper.render()).toMatchSnapshot();
   });
+
+  it('warning with invalidate value', () => {
+    resetWarned();
+    const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
+
+    const invalidateDate = moment('notValidate', 'YYYY', true);
+    mount(<MomentPickerPanel value={invalidateDate} />);
+    expect(errSpy).toHaveBeenCalledWith(
+      'Warning: Invalidate date pass to `value`.',
+    );
+
+    mount(<MomentPickerPanel defaultValue={invalidateDate} />);
+    expect(errSpy).toHaveBeenCalledWith(
+      'Warning: Invalidate date pass to `defaultValue`.',
+    );
+
+    errSpy.mockRestore();
+  });
 });