feat: Do not respond to the Enter event when data is loading #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Jun 6, 2024
Co-authored-by: afc163 <[email protected]>
afc163
reviewed
Jun 6, 2024
| // loading skip | ||
| if (loading) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
应该不用吧 这里关掉的话 就需要重新输入才会搜索了（input 里的text就不完整了）
afc163
reviewed
Jun 6, 2024
| @@ -101,6 +102,7 @@ const InternalMentions = forwardRef<MentionsRef, MentionsProps>( | |||
| options, | |||
| open, | |||
| allowClear, | |||
| silent, | |||
There was a problem hiding this comment.
loading 是 antd 中的，rc-mentions 里是没有 loading 态的
zombieJ
reviewed
Jun 6, 2024
| @@ -40,6 +40,10 @@ describe('Mentions', () => { | |||
| return render(createMentions(props)); | |||
| } | |||
|
|
|||
| beforeEach(() => { | |||
| jest.useFakeTimers(); | |||
There was a problem hiding this comment.
把下面的 beforeEach 和 afterEach 挪上来把，反正也是 fakeTimer
There was a problem hiding this comment.
把下面的 beforeEach 和 afterEach 挪上来把，反正也是 fakeTimer
done
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增 loading 字段
在异步加载数据场景下 当 loading=true 时不响应 Enter 事件