feat: mentions support allowClear #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 98.27% 98.31% +0.04%
==========================================
Files 7 7
Lines 232 238 +6
Branches 54 55 +1
==========================================
+ Hits 228 234 +6
Misses 4 4 ☔ View full report in Codecov by Sentry. |
20 tasks
20 tasks
MadCcc
reviewed
Dec 13, 2023
src/Mentions.tsx
Outdated
| value={value} | ||
| classes={{ | ||
| affixWrapper: classNames(classes?.affixWrapper, { | ||
| [`${prefixCls}-mentions-allow-clear`]: allowClear, |
There was a problem hiding this comment.
这个 className 被用来判断 textarea 是否应该增加右侧 padding，实际上可以判断有没有 suffix，所以这里可以不用加。
There was a problem hiding this comment.
等这个发版了，我再更新antd那边，否则CI还是过不了
MadCcc
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#46278