feat: support mouse wheel #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 94.34% 94.53% +0.19%
==========================================
Files 6 6
Lines 283 293 +10
Branches 72 75 +3
==========================================
+ Hits 267 277 +10
Misses 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yoyo837
reviewed
Oct 28, 2023
mvp-v
force-pushed
the
feat/support-mouse-wheel
branch
from
9da92e4 to
27cc6a0
Compare
yoyo837
reviewed
Oct 28, 2023
mvp-v
force-pushed
the
feat/support-mouse-wheel
branch
from
27cc6a0 to
b18ad09
Compare
mvp-v
force-pushed
the
feat/support-mouse-wheel
branch
from
b18ad09 to
223858a
Compare
Screencast.from.28-10-23.14.26.53.webmI've pushed fix to prevent page scrolling while changing input value with wheel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Mouse Wheel support to change value.
Mouse wheel up - increment, [SHIFT] +mouse wheel up - increment by 10 * step,
Mouse wheel down - decrement, [SHIFT] +mouse wheel down - decrement by 10 * step
note: moving mouse wheel up raises wheel event with negative deltaY (just write addEventListener('wheel', console.log) in dev console to check). Scrolling with touchbar is inverted (we should "touch" page and drag it to top to scroll bottom).
I've implemented the same behavior as DevExpress library has https://js.devexpress.com/React/Demos/WidgetsGallery/Demo/NumberBox/Overview/MaterialBlueLight/