feat: add warning "cannot be a function" in getValueProps #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zombieJ
reviewed
Dec 16, 2023
| @@ -578,9 +578,16 @@ class Field extends React.Component<InternalFieldProps, FieldState> implements F | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| const originTriggerFunc: any = childProps[trigger]; | |||
|
|
|||
| const valueProps = mergedGetValueProps(value); | |||
|
|
|||
| // warning when prop value is function | |||
zombieJ
reviewed
Dec 16, 2023
src/Field.tsx
Outdated
|
|
||
| // warning when prop value is function | ||
| Object.keys(valueProps).forEach(key => { | ||
| warning(typeof valueProps[key] !== 'function', `cannot return prop value is function in getValueProps (prop name: "${key}")`) |
There was a problem hiding this comment.
这个描述比较怪异，它不是不能返回。而是不推荐通过 getValueProps 动态添加 function。
zombieJ
reviewed
Dec 16, 2023
src/Field.tsx
Outdated
| // warning when prop value is function | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| Object.keys(valueProps).forEach(key => { | ||
| warning(typeof valueProps[key] !== 'function', `Not recommended return prop value is function in getValueProps (prop name: "${key}")`) |
There was a problem hiding this comment.
It's not recommended to generate dynamic function prop by
getValueProps. Please pass it to child component directly.
crazyair
reviewed
Dec 19, 2023
| // warning when prop value is function | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| Object.keys(valueProps).forEach(key => { | ||
| warning(typeof valueProps[key] !== 'function', `It's not recommended to generate dynamic function prop by \`getValueProps\`. Please pass it to child component directly (prop: ${key})`) |
There was a problem hiding this comment.
一直不知道 warning 第一个参数是 true 打印，还是 false 打印
There was a problem hiding this comment.
false hh 我也是看下面代码学的，下面代码也有用 warning 的
There was a problem hiding this comment.
所以我倾向
if(xx){
warning(false,'xx')
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
关联 PR ant-design/ant-design#46445
关联 issue ant-design/ant-design#46417
💡 Background and solution
根据 #46445 的改动为 getValueProps 的返回值加上一层 warning，判断返回值是否为 function 是 function 则给予提示
📝 Changelog
☑️ Self-Check before Merge