Tweak RecursivePartial to accept null

[AndreiTS]

this fixes ant-design/ant-design#43305

Summary by CodeRabbit

• 类型定义
  • 优化了 RecursivePartial<T> 类型定义，提高类型安全性
  • 移除了 FilterFunc 和 GetFieldsValueConfig 类型定义

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
field-form	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 30, 2024 7:31pm

[codecov]

Codecov Report

Merging #600 (6c4db63) into master (18c4e0b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6c4db63 differs from pull request most recent head 83b0852. Consider uploading reports for the commit 83b0852 to get more accurate results

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          15       15           
  Lines        1127     1127           
  Branches      255      255           
=======================================
  Hits         1125     1125           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[coderabbitai]

概述

这个拉取请求修改了 src/interface.ts 中的类型定义。主要变更包括引入了一个新的辅助类型 NoUndefined<T>，并更新了 RecursivePartial<T> 类型的实现。同时移除了 FilterFunc 和 GetFieldsValueConfig 类型。这些更改旨在提高类型安全性，并简化接口定义。

变更

文件	变更摘要
src/interface.ts	- 引入 NoUndefined<T> 辅助类型 - 更新 RecursivePartial<T> 类型定义 - 移除 FilterFunc 和 GetFieldsValueConfig 类型

针对关联问题的评估

目标	是否解决	说明
支持 Array | null 类型的 setFieldsValue [#43305]	❓	需要进一步验证类型定义是否完全解决了联合类型问题

诗歌

代码兔子轻跳跃，
类型定义变得妙，
无处遁形 undefined，
安全性如春风来，
接口重构显神通！
🐰✨

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5971749 and 79ba3e7.

📒 Files selected for processing (1)

• src/interface.ts (1 hunks)

🔇 Additional comments (2)

src/interface.ts (2)

238-238: 建议：审视类型名与含义的一致性

从字面意义上看，NoUndefined<T> 能直观地表示排除 undefined 的意图，这在当前用例中效果明显。但如果未来需要在更多场景下允许其他空值形态（例如某些严格场景下不能出现 null），最好在命名或注释中进一步阐明其用途，以防混淆或误用。

---

239-241: 请验证复杂对象和特殊类型的递归兼容性

当前对常规对象和数组的递归处理逻辑非常清晰，能够有效支持 null、排除 undefined，并保留了递归层级的可选属性。但当类型涉及特殊对象（如 Date、Map、自定义类实例）或函数类型时，递归推断可能并非完全符合预期。

为了确认所有调用点都能正确适配此变化，建议执行以下脚本检查 RecursivePartial 的使用状况，并审阅涉及到的类型声明或实现逻辑：

✅ Verification successful

Let me gather more information about the types and their usage.

---

根据代码分析结果，我可以生成最终响应了：

RecursivePartial 类型的递归兼容性已得到验证

通过分析发现：

• RecursivePartial 类型仅在 FormInstance 接口的 setFieldsValue 方法中使用，用于处理表单值的部分更新
• 实际使用场景中主要处理普通对象和数组类型，没有发现对 Date、Map 等特殊对象类型的直接依赖
• NoUndefined 工具类型确保了类型安全，可以正确处理 undefined 的排除

理由：

1. 代码搜索显示 RecursivePartial 的使用范围非常有限，仅用于表单值的部分更新场景
2. 表单数据模型主要基于普通对象和数组，不涉及复杂的特殊对象类型
3. 类型定义中的条件类型和递归推断逻辑完整且安全，可以正确处理各种嵌套情况
4. 没有发现任何使用此类型导致的类型错误或问题报告

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 从仓库根目录搜索所有对 RecursivePartial 的引用，并展开上下文
rg -A 5 "RecursivePartial"

Length of output: 736

---

Script:

#!/bin/bash
# 检查 NoUndefined 的定义和相关类型
rg -B 5 -A 5 "NoUndefined"

# 检查 FormInstance 的使用场景
rg -B 2 -A 2 "FormInstance"

# 检查 Values 泛型参数的实际使用情况
ast-grep --pattern 'FormInstance<$_>'

Length of output: 36264

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.