fix: form onValues second params values #582

elevensky · 2023-04-05T10:33:59Z

vercel · 2023-04-05T10:34:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
field-form	❌ Failed (Inspect)			Apr 23, 2023 11:46am

elevensky · 2023-04-10T07:18:08Z

@zombieJ 点Vercel 发布 failed details 404是啥情况？

codecov · 2023-04-11T05:57:54Z

Codecov Report

Merging #582 (1cb2178) into master (c2a6427) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1cb2178 differs from pull request most recent head 45e1676. Consider uploading reports for the commit 45e1676 to get more accurate results

@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          16       16           
  Lines        1143     1146    +3     
  Branches      257      258    +1     
=======================================
+ Hits         1141     1144    +3     
  Misses          2        2

Impacted Files	Coverage Δ
src/Field.tsx	`100.00% <100.00%> (ø)`
src/List.tsx	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zombieJ · 2023-04-11T06:01:36Z

要加一下对应的测试用例哈~

elevensky · 2023-04-12T09:37:19Z

要加一下对应的测试用例哈~

@zombieJ 看看ok不

zombieJ · 2023-04-12T09:37:32Z

ant-design/ant-design#41053 (comment) 这个看过了么？

elevensky · 2023-04-12T09:42:24Z

ant-design/ant-design#41053 (comment) 这个看过了么？

@zombieJ 看了，不过总有人会忘了加 {...field}，所以我加了默认的，然后测试用例模拟了下他那个例子

src/Field.tsx

src/ListContext.ts

zombieJ · 2023-04-17T09:13:20Z

src/Field.tsx

@@ -625,7 +626,8 @@ class Field extends React.Component<InternalFieldProps, FieldState> implements F

 function WrapperField<Values = any>({ name, ...restProps }: FieldProps<Values>) {
  const fieldContext = React.useContext(FieldContext);
-
+  const listContext = React.useContext(ListContext);
+  const mergedIsListField = restProps.isListField || (!restProps.isList && !!listContext);


这边这个 isList 的用途是什么哈？

@zombieJ 原来的代码是用来指定list本身的标识吧，我理解的它本身不属于inListField

这个是告诉 Field 当做 List 处理，不过这里我感觉是不需要的。因为它其实自动注入 isListField

@zombieJ 得加的吧，要不List的name收集值不就跳过去了么，

如果加了，对于直接 List 嵌套 List 的情况，这个 isListField 就没了。

嗯，明白了，我想想

@zombieJ List里面的Field也给个默认值，根据是否嵌套在List里面，看下还有啥问题没考虑到不。

close ant-design/ant-design#41053

tests/list.test.tsx

elevensky · 2023-04-24T11:16:52Z

@zombieJ 改了，再看看

closertb · 2023-06-29T08:48:53Z

这个pr改动，在某个场景下，会引起bug @elevensky @zombieJ ，具体描述看这里：#597

vercel bot had a problem deploying to Preview April 5, 2023 10:37 Failure

vercel bot had a problem deploying to Preview April 12, 2023 09:23 Failure

zombieJ reviewed Apr 12, 2023

View reviewed changes

src/Field.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Apr 12, 2023

View reviewed changes

src/Field.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Apr 12, 2023

View reviewed changes

src/ListContext.ts Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview April 12, 2023 11:30 Failure

zombieJ reviewed Apr 17, 2023

View reviewed changes

vercel bot had a problem deploying to Preview April 19, 2023 13:03 Failure

elevensky added 4 commits April 19, 2023 21:14

fix: form onValues second params values

9fed30e

close ant-design/ant-design#41053

test: improve list case

c89c7d2

fix: review

d1d5e2f

fix: list nest list

7b72c03

elevensky force-pushed the fix-onChange branch from e365bc6 to 7b72c03 Compare April 19, 2023 13:17

vercel bot had a problem deploying to Preview April 19, 2023 13:20 Failure

zombieJ reviewed Apr 20, 2023

View reviewed changes

tests/list.test.tsx Show resolved Hide resolved

test: add list case

ccce8b4

vercel bot had a problem deploying to Preview April 20, 2023 06:01 Failure

zombieJ reviewed Apr 23, 2023

View reviewed changes

tests/list.test.tsx Show resolved Hide resolved

zombieJ approved these changes Apr 23, 2023

View reviewed changes

fix: up

45e1676

vercel bot had a problem deploying to Preview April 23, 2023 11:46 Failure

zombieJ merged commit c6dab30 into react-component:master Apr 24, 2023

elevensky deleted the fix-onChange branch April 25, 2023 01:25

closertb mentioned this pull request Jun 28, 2023

listContext 造成useWatch 失效 #597

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: form onValues second params values #582

fix: form onValues second params values #582

elevensky commented Apr 5, 2023

vercel bot commented Apr 5, 2023 •

edited

Loading

elevensky commented Apr 10, 2023 •

edited

Loading

codecov bot commented Apr 11, 2023 •

edited

Loading

zombieJ commented Apr 11, 2023

elevensky commented Apr 12, 2023

zombieJ commented Apr 12, 2023

elevensky commented Apr 12, 2023 •

edited

Loading

zombieJ Apr 17, 2023

elevensky Apr 17, 2023 •

edited

Loading

zombieJ Apr 18, 2023

elevensky Apr 18, 2023 •

edited

Loading

zombieJ Apr 19, 2023 •

edited

Loading

elevensky Apr 19, 2023

elevensky Apr 19, 2023

elevensky commented Apr 24, 2023

closertb commented Jun 29, 2023

fix: form onValues second params values #582

fix: form onValues second params values #582

Conversation

elevensky commented Apr 5, 2023

vercel bot commented Apr 5, 2023 • edited Loading

elevensky commented Apr 10, 2023 • edited Loading

codecov bot commented Apr 11, 2023 • edited Loading

Codecov Report

zombieJ commented Apr 11, 2023

elevensky commented Apr 12, 2023

zombieJ commented Apr 12, 2023

elevensky commented Apr 12, 2023 • edited Loading

zombieJ Apr 17, 2023

Choose a reason for hiding this comment

elevensky Apr 17, 2023 • edited Loading

Choose a reason for hiding this comment

zombieJ Apr 18, 2023

Choose a reason for hiding this comment

elevensky Apr 18, 2023 • edited Loading

Choose a reason for hiding this comment

zombieJ Apr 19, 2023 • edited Loading

Choose a reason for hiding this comment

elevensky Apr 19, 2023

Choose a reason for hiding this comment

elevensky Apr 19, 2023

Choose a reason for hiding this comment

elevensky commented Apr 24, 2023

closertb commented Jun 29, 2023

vercel bot commented Apr 5, 2023 •

edited

Loading

elevensky commented Apr 10, 2023 •

edited

Loading

codecov bot commented Apr 11, 2023 •

edited

Loading

elevensky commented Apr 12, 2023 •

edited

Loading

elevensky Apr 17, 2023 •

edited

Loading

elevensky Apr 18, 2023 •

edited

Loading

zombieJ Apr 19, 2023 •

edited

Loading