fix: normalize as the same should not trigger onValuesChange (#731)

react-component · Oct 30, 2024 · df61d03 · df61d03
1 parent 38c629a
commit df61d03
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/src/Field.tsx b/src/Field.tsx
@@ -620,13 +620,13 @@ class Field extends React.Component<InternalFieldProps, FieldState> implements F
       if (normalize) {
         newValue = normalize(newValue, value, getFieldsValue(true));
       }
-
-      dispatch({
-        type: 'updateValue',
-        namePath,
-        value: newValue,
-      });
-
+      if (!isEqual(newValue, value)) {
+        dispatch({
+          type: 'updateValue',
+          namePath,
+          value: newValue,
+        });
+      }
       if (originTriggerFunc) {
         originTriggerFunc(...args);
       }

diff --git a/tests/control.test.tsx b/tests/control.test.tsx
@@ -40,4 +40,18 @@ describe('Form.Control', () => {
     await changeValue(getInput(container), ['bamboo', '']);
     matchError(container, "'test' is required");
   });
+
+  it('value no change', async () => {
+    const fn = jest.fn();
+    const { container } = render(
+      <Form onFieldsChange={fn}>
+        <InfoField name="test" normalize={value => value?.replace(/\D/g, '') || undefined} />
+      </Form>,
+    );
+
+    await changeValue(getInput(container), 'bamboo');
+    expect(fn).toHaveBeenCalledTimes(0);
+    await changeValue(getInput(container), '1');
+    expect(fn).toHaveBeenCalledTimes(1);
+  });
 });