Add throttling to contact api endpoint #1231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wallace <[email protected]>
Signed-off-by: David Wallace <[email protected]>
jochenklar
commented
Jan 23, 2025
| @@ -334,6 +334,11 @@ def visibility(self, request, pk=None): | |||
| throttle_classes=[EmailThrottle]) | |||
| def contact(self, request, pk): | |||
| if settings.PROJECT_CONTACT: | |||
| try: | |||
| project = self.get_object() | |||
There was a problem hiding this comment.
The self.get_object() (permission handling) is needed by the try ... except is not. Since I am not sold on the caching thing yet, I will fix this in the original branch.
jochenklar
commented
Jan 23, 2025
| @@ -151,7 +151,8 @@ def test_contact_get_set(db, client): | |||
|
|
|||
| @pytest.mark.parametrize('username,password', users) | |||
| @pytest.mark.parametrize('project_id', projects) | |||
| def test_contact_post(db, client, username, password, project_id): | |||
| def test_contact_post(db, client,settings, username, password, project_id): | |||
| assert settings.PROJECT_CONTACT | |||
There was a problem hiding this comment.
Why do we need to check this here?
There was a problem hiding this comment.
it's easier to know what this test is for like that and what the feature flag does..
|
caching, with database caching as default, is not a required feature and may be an option only after the dependency on the compressor is resolved (eg. with bs5). So, it might be an option after 2.4 when there are any issues that can be resolved by caching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds throttling to the contact api endpoint.