Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interview): Reuse datasets and values [5] #1188

Merged
merged 42 commits into from
Jan 31, 2025
Merged

feat(interview): Reuse datasets and values [5] #1188

merged 42 commits into from
Jan 31, 2025

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Nov 8, 2024 •
edited
Loading

This PR adds the possibility to reuse set and single values from every project and snapshot the user has access to.

@jochenklar jochenklar mentioned this pull request Nov 12, 2024
Draft
@jochenklar jochenklar changed the title Interview import dataset feature(interview): Reuse datasets and values [6] Nov 19, 2024
@jochenklar jochenklar changed the title feature(interview): Reuse datasets and values [6] feature(interview): Reuse datasets and values [5] Nov 19, 2024
@jochenklar jochenklar changed the title feature(interview): Reuse datasets and values [5] feat(interview): Reuse datasets and values [5] Nov 19, 2024
@jochenklar jochenklar self-assigned this Nov 19, 2024
@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Nov 19, 2024
@jochenklar jochenklar force-pushed the interview-copy-dataset branch from 01d9ef8 to b453485 Compare January 10, 2025 13:12
Base automatically changed from interview-copy-dataset to 2.3.0 January 17, 2025 14:54
@jochenklar
Add import function to create set modal on pages
b73ffbc
@jochenklar
Add separate search endpoint for values and use AsyncSelect in PageHe…
a687222 
…adFormModal
@jochenklar
Fix errors after rebase
3cffcac
@jochenklar
Add error handling to copy-set action and fix/add tests
1c470db
@jochenklar
Improve PageHeadFormModal
485f917
@jochenklar
Add import function into existing set
0bf452a
@jochenklar
Update/fix tests
f6b813e
@jochenklar
Rename import/copy answers to reuse answers
81f484d
@jochenklar
Fix copy_set action and update tests
5bfbd6f
@jochenklar
Add reuse value modal for questions
27d3369
@jochenklar
Add reuse value model to checkboxes
d5cdce3
@jochenklar
Add project filter to reuse value modal
60eaf38
@jochenklar
Add useLsState hook and use it to store reuse modal information
d8552ce
@jochenklar
Fix page component
55eaaf2
@jochenklar
Fix react select error state
11ba0e5
@jochenklar
Fix reuse modal
332c2ac
@jochenklar
Add tests for value search endpoint
9931832
@jochenklar
Fix QuestionSetCopySet component
cc742b4
@jochenklar
Fix Page component
cd0a0e6
@jochenklar jochenklar force-pushed the interview-import-dataset branch from 4ca340d to f77ea87 Compare January 23, 2025 16:59
@jochenklar jochenklar marked this pull request as ready for review January 24, 2025 14:45
@jochenklar
Copy link
Member Author

Rebased and ready for review. I added two things:

  • The search endpoint now filters for option=... query parameters, so that a question with options only looks for values with options and the other way around.
  • When reusing a set, the server loops checks the question(s) for the new value if it has optionsets or not and skips the value if the options in not in the questions optionsets.

@MyPyDavid MyPyDavid self-requested a review January 24, 2025 15:03
@jochenklar jochenklar mentioned this pull request Jan 24, 2025
Draft
MyPyDavid
MyPyDavid requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few minor remarks, otherwise think its good to go for release candidate testing for example..

@jochenklar jochenklar requested a review from MyPyDavid January 30, 2025 17:14
MyPyDavid
MyPyDavid approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users can now import their Answers and Datasets from other projects! ✍️
thanks! 🙏

@jochenklar jochenklar merged commit 4579339 into 2.3.0 Jan 31, 2025
17 of 19 checks passed
@jochenklar jochenklar deleted the interview-import-dataset branch January 31, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

Assignees

@jochenklar jochenklar

Labels
None yet
Projects
None yet
Milestone
RDMO 2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenklar @MyPyDavid