Open
Conversation
RDKEMW-12849: Update to print logs to console Reason for change: RDKLogger sends the output directly to syslog to gain the performance. But the platform components like `rdkfwupdater`, `rfc`, `rdm`, `logupload` & `crashupload` are spun by scripts and console output are redirected to file manually. So, for these components, we have to configure logger to print to console instead syslog. Once these components become standalone and launched by systemd service independently, this change can be removed to gain performance. Test Procedure: Ensure logs from above mentioned components are printed. Risks: None. In the past also output was redirected; so whatever gained in last 2 weeks is not present anymore. Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RDK logger initialization in the utils module to use the extended logger API with explicit configuration instead of file-based initialization.
Changes:
- Added
rdk_logger.hinclude to support the new extended logger API - Replaced
rdk_logger_init(DEBUG_INI_NAME)withrdk_logger_ext_init(&cfg)using explicit configuration parameters - Configured logger with INFO level, console output, and detailed timestamp format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utils/rdkv_cdl_log_wrapper.h | Added include for rdk_logger.h to support extended logger API |
| utils/rdkv_cdl_log_wrapper.c | Migrated from file-based logger initialization to explicit configuration using rdk_logger_ext_init with structured parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.