RDK-57502 - [RDKE] Migrate Operation Support Log Upload Related Scripts To C Implementation#70
RDK-57502 - [RDKE] Migrate Operation Support Log Upload Related Scripts To C Implementation#70Abhinavpv28 wants to merge 12 commits intodevelopfrom
Conversation
|
Builds |
There was a problem hiding this comment.
Pull request overview
This PR fixes a build error that occurs when the rdkcertselector flag is disabled. The issue was caused by incorrect placement of conditional compilation directives in mtls_upload.c.
Changes:
- Corrected the placement of
#endifdirective inmtls_upload.cto properly close the#ifdef LIBRDKCERTSELECTORblock - Updated Makefile.am to use library-specific LDFLAGS instead of global AM_LDFLAGS for linking RdkCertSelector
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uploadutils/mtls_upload.c | Fixed conditional compilation structure by moving #endif from end of file to line 213, ensuring performS3PutWithCert is available even when LIBRDKCERTSELECTOR is disabled |
| uploadutils/Makefile.am | Changed from global AM_LDFLAGS to library-specific libuploadutil_la_LDFLAGS for RdkCertSelector linker flags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
satya200
left a comment
satya200
left a comment
There was a problem hiding this comment.
With this change the upload functionality is got removed. Please make sure upload functionality should work when certselecter flag is disable and the code should continue with non mils path.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uploadutils/mtls_upload.c
Outdated
| int result = performS3PutUpload(s3_url, src_file, sec); | ||
| if (result == 0) { |
There was a problem hiding this comment.
There are trailing whitespaces on these lines. The empty line 224 contains spaces, and line 225 has trailing spaces after the semicolon. These should be removed to maintain code cleanliness.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mTLS is the default and certselector is expected to be enabled, which aligns with what other components like rdm, rfc are following right now. |
|
yes we have the cert selector in rdkcentral also as per security team so it can be used |
3 participants
Reason for change: Resolve build error , on disabing rekcertselector flag
Test Procedure: Focused Regression
Risks: Low
Signed-off-by: Abhinav P V Abhinav_Valappil@comcast.com