Feature/copilot twostage by Abhinavpv28 · Pull Request #66 · rdkcentral/common_utilities

Abhinavpv28 · 2025-12-08T06:45:38Z

No description provided.

Removed the get_system_uptime function declaration and its documentation.

Initial implementation of codebig utility functions for signing and URL handling.

.github/workflows/L1-Test.yaml

+    name: Execute L1 test suite in test container environment
    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/rdkcentral/docker-rdk-ci:latest

    steps:
      - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+
+      - name: Log in to GitHub Container Registry
+        uses: docker/login-action@v2
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Pull test container image
+        run: docker pull ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest
+
+      - name: Start test container
+        run: |
+          docker run -d --name native-platform -v ${{ github.workspace }}:/mnt/L1_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest

-      - name: Run unit tests
-        run: sh unit_test.sh
+      - name: Run L1 Unit Tests inside container
+        run: docker exec -i native-platform /bin/bash -c "cd /mnt/L1_CONTAINER_SHARED_VOLUME/ && sh unit_test.sh"

-      - name: Upload test results to automatic test result management system
+      - name: Copy L1 test results to runner
+        run: |
+          docker cp native-platform:/tmp/Gtest_Report /tmp/Gtest_Report
+          ls -l /tmp/Gtest_Report
+
+  upload-test-results:


To fix the problem, explicitly add a permissions block to the workflow, restricting the permissions of the GITHUB_TOKEN to the minimum required to complete the workflow tasks. In this context, setting contents: read at the workflow root is appropriate and restricts repository access to read-only for all jobs (unless overridden per-job). This change should be made near the top of the YAML, right after the workflow name, but before on so that it applies globally. No code outside this YAML file needs to be modified, no imports are required, and no existing functionality changes.

rdkcmf-jenkins · 2025-12-08T06:46:37Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 4 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: d320f1d

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T06:52:56Z

uploadutils/uploadUtil.c

+    curl_off_t filesize = ftell(fp);
+    fseek(fp, 0, SEEK_SET);
+
+    curl_easy_setopt(curl, CURLOPT_PUT, 1L);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, 1L)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-12-08T06:52:56Z

uploadutils/uploadUtil.c

+    fseek(fp, 0, SEEK_SET);
+
+    curl_easy_setopt(curl, CURLOPT_PUT, 1L);
+    curl_easy_setopt(curl, CURLOPT_READDATA, fp);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, fp)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-12-08T06:52:56Z

uploadutils/uploadUtil.c

+
+    curl_easy_setopt(curl, CURLOPT_PUT, 1L);
+    curl_easy_setopt(curl, CURLOPT_READDATA, fp);
+    curl_easy_setopt(curl, CURLOPT_INFILESIZE_LARGE, filesize);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, filesize)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-12-08T06:52:56Z

uploadutils/uploadUtil.c

+    curl_easy_setopt(curl, CURLOPT_PUT, 1L);
+    curl_easy_setopt(curl, CURLOPT_READDATA, fp);
+    curl_easy_setopt(curl, CURLOPT_INFILESIZE_LARGE, filesize);
+    curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, 1L)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-12-08T06:52:56Z

uploadutils/uploadUtil.c

+        snprintf(postfields, sizeof(postfields), "filename=%s",
+                 pfile_upload->pathname);
+    }
+    curl_easy_setopt(curl, CURLOPT_POSTFIELDS, postfields);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, postfields)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-12-08T06:52:56Z

uploadutils/uploadUtil.c

+        if (headers) curl_slist_free_all(headers);
+        return (int)UPLOAD_FAIL;
+    }
+    curl_easy_setopt(curl, CURLOPT_WRITEDATA, resp_fp);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, resp_fp)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-12-08T06:52:56Z

uploadutils/uploadUtil.c

+        return (int)UPLOAD_FAIL;
+    }
+    curl_easy_setopt(curl, CURLOPT_WRITEDATA, resp_fp);
+    curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, 1L)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-12-08T08:17:29Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 4 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 0dbf467

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T08:20:45Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 4 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 2c754a9

Report detail: gist'

Removed the old comment block and updated to a new format.

rdkcmf-jenkins · 2025-12-08T10:53:50Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: eb571b8

Report detail: gist'

Updated copyright notice format in codebigUtils.c

rdkcmf-jenkins · 2025-12-08T10:56:21Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 8a050c1

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T10:57:34Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 8a050c1

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T10:58:21Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 8a050c1

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T11:00:00Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 8a050c1

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T11:01:54Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 98e22d8

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T11:07:08Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: b818a4d

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T11:09:19Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: b818a4d

Report detail: gist'

Removed unnecessary comments from the file.

rdkcmf-jenkins · 2025-12-08T11:39:19Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 6a4c14b

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T11:41:44Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 6a4c14b

Report detail: gist'

mhughesacn · 2025-12-08T15:46:34Z

Please add a credit for RDK Management (below) to the end of NOTICE at top level, or replace the RDK header with a Comcast one if this is indeed Comcast code.

Copyright 2025 RDK Management
Licensed under the Apache License, Version 2.0

Removed unnecessary comment block from the test file.

rdkcmf-jenkins · 2025-12-08T17:10:20Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 113b3a1

Report detail: gist'

rdkcmf-jenkins · 2025-12-08T17:11:06Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 113b3a1

Report detail: gist'

rdkcmf-jenkins · 2025-12-10T11:35:19Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 6 files pending identification.

Protex Server Path: /home/blackduck/github/common_utilities/66/rdkcentral/common_utilities
Commit: 028edf9

Report detail: gist'

Valappil, Abhinav (Contractor) and others added 22 commits December 5, 2025 13:08

logupload

fed0d6c

Add files via upload

892db87

Update Makefile.am

22ada22

Add support for CPC code in configure.ac

664cb05

Create readme.doc

94c1146

Add files via upload

e077ed1

Delete uploadutil directory

ff77009

Delete uploadutils/readme.doc

baec6d6

Update Makefile.am

28a87e7

Update system_utils.c

7b93c34

Remove get_system_uptime function declaration

e008a8f

Removed the get_system_uptime function declaration and its documentation.

Update upload_status.c

49bf54c

Update upload_status.h

c72bc92

Add files via upload

37a7e24

Add files via upload

a7d8e7a

Update mtls_upload.c

97927a5

Add files via upload

97af4b7

Refactor GitHub Actions for L1 Unit Tests

c796ea2

Add codebigUtils.c with utility functions

a2f6259

Initial implementation of codebig utility functions for signing and URL handling.

Add codebigUtils.h header file with utility functions

97cddeb

Update Makefile.am

c7914ab

Update codebigUtils.c

d320f1d

Abhinavpv28 requested a review from a team as a code owner December 8, 2025 06:45

github-advanced-security bot found potential problems Dec 8, 2025

View reviewed changes

rdkcmf-jenkins reviewed Dec 8, 2025

View reviewed changes

Update Makefile.am

0dbf467

Add files via upload

2c754a9

Abhinavpv28 added 3 commits December 8, 2025 16:22

Update comment block format in codebig_upload_gtest.cpp

586da49

Removed the old comment block and updated to a new format.

Update mtls_upload_gtest.cpp

eb571b8

Update copyright notice in uploadUtil_gtest.cpp

3aecb98

Abhinavpv28 added 3 commits December 8, 2025 16:24

Update copyright header in upload_status_gtest.cpp

d428ca6

Fix copyright notice formatting in codebigUtils.c

b4f753b

Updated copyright notice format in codebigUtils.c

Update codebigUtils.h

8a050c1

Update codebig_upload_gtest.cpp

98e22d8

Update codebig_upload_gtest.cpp

b818a4d

Abhinavpv28 added 2 commits December 8, 2025 16:41

Update codebig_upload_gtest.cpp

8800604

Clean up comments in codebig_upload_gtest.cpp

6a4c14b

Removed unnecessary comments from the file.

Abhinavpv28 closed this Dec 8, 2025

github-actions bot locked and limited conversation to collaborators Dec 8, 2025

Abhinavpv28 reopened this Dec 8, 2025

Abhinavpv28 added 2 commits December 8, 2025 22:37

Update codebig_upload_gtest.cpp

e647f73

Clean up codebig_upload_gtest.cpp

113b3a1

Removed unnecessary comment block from the test file.

Update CFLAGS for libuploadutil with LIBRDKCERTSEL_FLAG

028edf9

@@ -1,4 +1,6 @@
             name: L1 Unit Tests
+            permissions:
+              contents: read
             on:
               push:

Conversation

Abhinavpv28 commented Dec 8, 2025

Uh oh!

Check warning

Copilot Autofix

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

mhughesacn commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 8, 2025

Uh oh!

rdkcmf-jenkins commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

rdkcmf-jenkins Dec 8, 2025 •

edited

Loading

rdkcmf-jenkins Dec 8, 2025 •

edited

Loading

rdkcmf-jenkins Dec 8, 2025 •

edited

Loading

rdkcmf-jenkins Dec 8, 2025 •

edited

Loading

rdkcmf-jenkins Dec 8, 2025 •

edited

Loading

rdkcmf-jenkins Dec 8, 2025 •

edited

Loading

rdkcmf-jenkins Dec 8, 2025 •

edited

Loading