Skip to content

Rebase #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muraliselvaraj2020 wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Rebase #62

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d98289a
Update urlHelper.c
muraliselvaraj2020 Jul 17, 2025
1ee131e
Update urlHelper.c
muraliselvaraj2020 Jul 17, 2025
f136f0e
Update urlHelper.c
muraliselvaraj2020 Jul 19, 2025
279cfd9
Update urlHelper.c
muraliselvaraj2020 Jul 19, 2025
5578164
Update urlHelper.c
muraliselvaraj2020 Jul 20, 2025
3ef132b
Merge branch 'rdkcentral:develop' into develop
muraliselvaraj2020 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions dwnlutils/urlHelper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,19 +184,27 @@ CURLcode setMtlsHeaders(CURL *curl, MtlsAuth_t *sec) {
return code;
}
COMMONUTILITIES_INFO("%s: certfile:%s:cert type:%s\n", __FUNCTION__, sec->cert_name, sec->cert_type);

#if 1
#ifdef LIBRDKCERTSELECTOR
COMMONUTILITIES_INFO("%s: engine type:%s\n", __FUNCTION__, sec->engine);
if (sec->engine[0] == '\0') {
code = curl_easy_setopt(curl, CURLOPT_SSLENGINE_DEFAULT, 1L);
printf("DBG: Def : software engine \n");
}else{
code = curl_easy_setopt(curl, CURLOPT_SSLENGINE, sec->engine);
printf("DBG: ##### sec->engine (certselector condition success) ####### is %s \n", sec->engine);
}
// printf("DBG: ##### sec->engine (certselector) ####### is %s \n", sec->engine);
#else
code = curl_easy_setopt(curl, CURLOPT_SSLENGINE_DEFAULT, 1L);
#endif
printf("DBG: software engine \n");
#endif
#endif
printf("DBG: ##### Forcefully to set pkcs11 \n");
code = curl_easy_setopt(curl, CURLOPT_SSLENGINE, "pkcs11");
curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Unchecked return value from library

Calling "curl_easy_setopt(curl, _curl_opt, 1L)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

if(code != CURLE_OK) {
COMMONUTILITIES_ERROR("%s : Curl CURLOPT_SSLENGINE_DEFAULT failed with error %s\n", __FUNCTION__, curl_easy_strerror(code));
COMMONUTILITIES_ERROR("%s : Curl ############# CURLOPT_SSLENGINE_DEFAULT failed with error %s\n", __FUNCTION__, curl_easy_strerror(code));
}
do {
if((strcmp(sec->cert_type, "P12")) == 0) {
Expand Down
Loading