Fix page faults on QEMU #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conformance to the RISC-V standard
As per the RISC-V manual (20211203):
The current implementation blindly sets the D and A bits for all PTEs including non-leaf ones,
which, worked totally fine until QEMU starts to enforce this requirement in b6ecc63c (that is, for 7.0.0 versions and up):
U540 Compatibility
Yes, the hardware might still raise page faults when it does not support writing to A/D bits at all.
But instead of in a utility library I presume that this should be handled by the OS (for example,
by setting the A/D bits or simulating the behavior in their trap handler).
But anyway, this is a breaking change.