Fix #269 Consider the default variable value in FROM

Signed-off-by: Remy Suen <[email protected]>

CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [Unreleased]
+### Fixed
+- textDocument/publishDiagnostics
+  - consider default value of a variable when determining if FROM is invalid or not ([#269](https://github.com/rcjsuen/dockerfile-language-server/issues/269))
+
 ## [0.12.0] - 2024-05-23
 ### Added
 - textDocument/definition

package.json

@@ -20,8 +20,8 @@
     "node": "*"
   },
   "dependencies": {
-    "dockerfile-language-service": "0.13.0",
-    "dockerfile-utils": "0.16.0",
+    "dockerfile-language-service": "0.14.0",
+    "dockerfile-utils": "0.16.1",
     "vscode-languageserver": "~8.0.0",
     "vscode-languageserver-textdocument": "~1.0.8"
   },

test/server.test.ts

@@ -2284,6 +2284,36 @@ describe("Dockerfile LSP Tests", function() {
 		});
 	});
 
+	it("issue #269", (finished) => {
+		this.timeout(5000);
+
+		const documentURI = "uri://dockerfile/269.txt";
+		const diagnosticsListener = (json) => {
+			if (json.method === "textDocument/publishDiagnostics") {
+				if (json.params.uri === documentURI) {
+					lspProcess.removeListener("message", diagnosticsListener);
+					sendNotification("textDocument/didClose", {
+						textDocument: {
+							uri: documentURI,
+						}
+					});
+					assert.strictEqual(json.params.diagnostics.length, 0);
+					finished();
+				}
+			}
+		};
+		lspProcess.on("message", diagnosticsListener);
+
+		sendNotification("textDocument/didOpen", {
+			textDocument: {
+				languageId: "dockerfile",
+				version: 1,
+				uri: documentURI,
+				text: "FROM ${VAR:-alpine}"
+			}
+		});
+	});
+
 	after(() => {
 		// terminate the forked LSP process after all the tests have been run
 		lspProcess.kill();