add notification listener to disconnect once the printer is ready #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashbork
changed the title
|
Thanks @ashbork, that looks great. I will give it a test later today. |
|
Thanks @ashbork! |
|
Sorry for not responding, I was on vacation. Yep, the event is still going through for me! Thank you for that change, the timeout should've been there in the first place :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just waiting for 30s, we're listening for the printer's notifications. My testing suggests this is working well - I can run the script twice in a row without the hard-coded delay and the printer seems to have enough time to receive the next print instructions. I'm not 100% sure about the notification itself, but another project uses it for showing the print status and it looks like that's working out for them.