Fix warnings when using HW

raydouglass · Sep 13, 2023 · 5506501 · 5506501
1 parent c1f9137
commit 5506501
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/media_management_scripts/convert.py b/media_management_scripts/convert.py
@@ -151,6 +151,7 @@ def convert_with_config(
         VideoCodec.H264.equals(config.video_codec)
         and config.bitrate is not None
         and config.bitrate != "disabled"
+        and not config.hardware_nvidia
     ):
         crf = 1
         # -x264-params vbv-maxrate=1666:vbv-bufsize=3332:crf-max=22:qpmax=34
@@ -167,7 +168,11 @@ def convert_with_config(
     ):
         raise Exception("Avg Bitrate not supported for H265")
 
-    args.extend(["-crf", str(crf), "-preset", config.preset])
+    if not config.hardware_nvidia:
+        args.extend(["-crf", str(crf)])
+
+    args.extend(["-preset", config.preset])
+
     if config.deinterlace:
         is_interlaced = metadata.interlace_report.is_interlaced(
             config.deinterlace_threshold