Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validateRayServiceSpec #2711

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

hcc429
Copy link
Contributor

@hcc429 hcc429 commented Jan 3, 2025

Why are these changes needed?

refactor validateServiceSpec

Related issue number

Closes #2710

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 self-assigned this Jan 3, 2025
@kevin85421 kevin85421 merged commit a7197c5 into ray-project:master Jan 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] Check whether UpgradeStrategy is nil and UpgradeStrategy.Type is valid in a single if statement
2 participants