Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Replace Hard-Coded HTTP Values with Constants #2702

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[Refactor] Replace Hard-Coded HTTP Values with Constants #2702

merged 1 commit into from
Jan 3, 2025

Conversation

simotw
Copy link
Contributor

@simotw simotw commented Dec 31, 2024

Why are these changes needed?

Refactored the code to use HTTP constants instead of hard-coded numeric values, improving readability and maintainability.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@simotw simotw marked this pull request as ready for review December 31, 2024 07:37
@simotw simotw marked this pull request as draft December 31, 2024 08:09
@simotw simotw force-pushed the refactor/use-http-const branch from 877a6a1 to d7703eb Compare January 2, 2025 02:32
@simotw simotw marked this pull request as ready for review January 2, 2025 15:14
@simotw
Copy link
Contributor Author

simotw commented Jan 3, 2025

@kevin85421 PTAL.

@kevin85421 kevin85421 merged commit 542f246 into ray-project:master Jan 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simotw @kevin85421