Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add kuberay- name prefix to validating webhook Service #1729

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: add kuberay- name prefix to validating webhook Service #1729

merged 1 commit into from
Dec 11, 2023

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Dec 11, 2023 •
edited
Loading

and ValidatingWebhookConfiguration so they have more specific names of kuberay-webhook-service and kuberay-validating-webhook-configuration instead of the generic webhook-service and
validating-webhook-configuration, respectively.

The Service is in the ray-system namespace so it's unlikely to conflict with another Service's name in this namespace. But ValidatingWebhookConfigurations are cluster-scoped, so it's likely to conflict with another one that's also named validating-webhook-configuration.

Diff

running bin/kustomize build config/default-with-webhooks before and after, the diff is

Service

50131c50131
<   name: webhook-service
---
>   name: kuberay-webhook-service

Certificate

50252,50253c50252,50253
<   - webhook-service.ray-system.svc
<   - webhook-service.ray-system.svc.cluster.local
---
>   - kuberay-webhook-service.ray-system.svc
>   - kuberay-webhook-service.ray-system.svc.cluster.local

ValidatingWebhookConfiguration

50286c50286
<   name: validating-webhook-configuration
---
>   name: kuberay-validating-webhook-configuration
50292c50292
<       name: webhook-service
---
>       name: kuberay-webhook-service

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@davidxia
chore: add kuberay- name prefix to validating webhook Service
f6d6f34 
and ValidatingWebhookConfiguration so they have more specific names of
`kuberay-webhook-service` and `kuberay-validating-webhook-configuration`
instead of the generic `webhook-service` and
`validating-webhook-configuration`, respectively.

The Service is in the `ray-system` namespace so it's unlikely to conflict with
another Service's name in this namespace. But `ValidatingWebhookConfigurations`
are cluster-scoped, so it's likely to conflict with another one that's also
named `validating-webhook-configuration`.
@davidxia davidxia marked this pull request as ready for review December 11, 2023 13:48
@davidxia
Copy link
Contributor Author

cc @kevin85421

kevin85421
kevin85421 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevin85421 kevin85421 merged commit 747168f into ray-project:master Dec 11, 2023
25 checks passed
@davidxia davidxia deleted the dxia/webhook-name-prefix branch December 11, 2023 18:02
@davidxia
Copy link
Contributor Author

davidxia commented Dec 11, 2023 •
edited
Loading

by the way, filed upstream issue here to see if kubebuilder maintainers will support customizing the name with markers instead of kustomize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidxia @kevin85421