Converted Scripting pages from wiki to mkdocs#19
Conversation
- Fixed a small linkage issue in README.md related to the CONTRIBUTE located in guides folder, not the root folder. - Fixed another linkage issue in installing.md, adding the "installing" path to docker and debian. - Added the mysql.md based on [this](https://github.com/rathena/rathena/wiki/Install-MySQL)
Update GitHub Pages artifact to v3
Revert last commit
…-user-guides into docs/scripting
Danil0v3s
left a comment
Danil0v3s
left a comment
There was a problem hiding this comment.
Why is the script_commands left out? xD
Are you planning on doing it on a following PR?
| Script Syntax | ||
| ------------- | ||
|
|
||
| > string\[32\](*map_name*),ushort(*x*),ushort(*y*)\[,short(*x2*) = 0\[,short(*y2*) = 0\]\] <TAB> **monster** string\[24\](*name*) <TAB> short(*mob_id*),ushort(*amount*)\[,uint(*delay*)= 0\[,uint(*variance*) = 0\[,string\[50\](*event*)\] = null\]\] |
There was a problem hiding this comment.
I think this should be using code blocks instead
There was a problem hiding this comment.
Like mentioned in the main post, I still need to format most files.
|
It's linked to the script_commands.txt, should be enough xD. I mean I won't copy & paste it. |
Following that line of thought we could just link everything back to txt, couldn't we? |
|
Na that was just like it was originally on the wiki, also those pages should represent a guide itself not just links. The only thing are the commands themself which are basically explained there already. |
Just so I don't hijack your PR, here's what claude yield when I asked it to follow your format fo the script_commands.txt |
|
Well technically it would end up up the decision of Akky and others if they want that or not. Cuz if there will be new script commands or similar those would need to be updated again it's just linking to the actual txt file. |
What you mean, others? I'm the others as well xD I can approve/merge this or deny. I wouldn't be wasting my time reviewing PRs if I couldn't |
|
Well, I don't know if you have discussions about PR's (except maybe smaller ones) or not. Regarding script_commands.txt, I don't really care if that's also included. Personally I'm using the file itself look up stuff not the wiki in that regard. But like I meant, personally I don't see the point in that, that's why I didn't add them directly. |
|
Different thing, how would you view these Annotations from mkdocs? |
I'll be converting it back to draft then, since you're still actively working on it! When you're done and ready to merge you mark it as ready for review again, please.
These should be fine I guess? most docs use these as well |
|
Alright thanks, I'm nearly done via basic formating. I just tried the annotate thingy on error page: Wanted to make sure first, because that file has 2531 lines total xD. |
2 participants
Converted all available pages from rAthena Wiki regarding scripting.
Also updated the Deploy_Guides.yml regarding GitHub Pages artifacts being outdated.
ToDo:
Live Demo can be viewed here.
The workflow is manually executed based on the docs/scripting branch.
If anybody still has older mediawiki pages, let me know so I can add them if needed.