Conversation
This was referenced Apr 29, 2022
Owner
|
Aloha @jaller94 - thanks for all your updates here, I'm a bit hesitant of merging them right away as I see it more as a decorative update of the code generated by your CoffeeScript converter. Just to keep you in the loop, MapSCII v2 is slowly progressing in the currently limited free time (with some fundamental refactors for usability of MapSCII from inside other cli applications and a full switch, as already desired back then, to TypeScript). I would recommend limiting the time spent on updating/beautifying the current codebase - next to security patches. Cheers! |
Contributor
Author
|
Hi @rastapasta, all my PRs so far have been hand-translated. I didn't use a converter. This PR and #117 are pretty good refactors, even if Mapscii 2 is on its way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More and more of our dependencies transitioned to ESM.
To keep up with security fixes, it seems that we need to transition to ESM as well.
Merging after 1 week, if no one reviews this.