Skip to content

Add support for wiznet_w5100s_evb_pico2 #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

scaprile
Copy link

@scaprile scaprile commented May 7, 2025

This board has an RP2350 and a smaller 2MB flash
Building for this board requires manually setting flash size. There already is a board definition for its RP2040 sibling, why not adding one for this board ?
No related issues

This board has an RP2350 and a smaller 2MB flash

Signed-off-by: Sergio R. Caprile <[email protected]>
@lurch lurch self-requested a review May 7, 2025 16:54
Signed-off-by: Sergio R. Caprile <[email protected]>
@scaprile scaprile requested a review from lurch May 7, 2025 17:12
@lurch
Copy link
Contributor

lurch commented May 8, 2025

This is missing a #define PICO_RP2350A 1 line (see e.g. https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2.h#L22-L23 ) which tells the SDK whether this board is fitted with an RP2350A or an RP2350B.

Signed-off-by: Sergio R. Caprile <[email protected]>
Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants